public inbox for [email protected]  
help / color / mirror / Atom feed
From: Justin Pryzby <[email protected]>
To: Pavel Stehule <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: Jaime Casanova <[email protected]>
Cc: Erik Rijkers <[email protected]>
Cc: Gilles Darold <[email protected]>
Cc: [email protected]
Cc: Michael Paquier <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Robert Haas <[email protected]>
Subject: Re: Schema variables - new implementation for Postgres 15
Date: Mon, 15 Nov 2021 14:23:52 -0600
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAFj8pRA1MGp2Vj0x2v7dyGHc9Kk5Eqp-XfizqeO-61upPwX+eQ@mail.gmail.com>
References: <[email protected]>
	<CAFj8pRDfJ4nC7MV2jK=E63_9M7Bf6+qP1sSYYQuEekWpCzbMNA@mail.gmail.com>
	<20210912021338.GA21136@ahch-to>
	<CAFj8pRA-y9aTVwYPuVcdLpeb1F5M4n_mDmz-eec3ipJsC79GeA@mail.gmail.com>
	<CAFj8pRDN+B4OWkcanLa82BpqJqePEFcTzvu=pJFu=z+aTb9EXg@mail.gmail.com>
	<CAFj8pRAPcF7u_rV_2p=vaGFf8UkW1-Z7kef4rTFpsgy8JROH_w@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAFj8pRBjggW=HqVhhVJR9qTUymmRPDxCf70nizXeE9QRxvA+zw@mail.gmail.com>
	<CAFj8pRA1MGp2Vj0x2v7dyGHc9Kk5Eqp-XfizqeO-61upPwX+eQ@mail.gmail.com>

On Mon, Nov 15, 2021 at 09:00:13PM +0100, Pavel Stehule wrote:
> Thank you for review and fixes, I try to complete some version for next
> work, and looks so your patch 0001 is broken
> 
> gedit reports to me broken unicode \A0\A0\A0\A0\A0
> 
> my last patch has 276KB and your patch has 293KB?

On Mon, Nov 15, 2021 at 09:06:08PM +0100, Pavel Stehule wrote:
> >
> > my last patch has 276KB and your patch has 293KB?
> 
> Please, can you resend your version of patch 0001?

https://www.postgresql.org/message-id/[email protected]

0001 is exactly your patch applied to HEAD, and 0002 are Tomas' changes
relative to your patch.

0003 is my contribution on top.  My intent is that you wouldn't apply 0001, but
rather apply my 0003 on top of your existing branch, and then review 0002/0003,
and then squish the changes into your patch.

I see the 0xa0 stuff in your original patch before my changes, but I'm not sure
what went wrong.

Let me know if you have any issue applying my changes on top of your existing,
local branch ?

-- 
Justin





view thread (188+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Schema variables - new implementation for Postgres 15
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox