Date: Mon, 15 Nov 2021 19:44:21 -0300
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>,
	Zhihong Yu <zyu@yugabyte.com>,
	Daniel Westermann <dwe@dbi-services.com>,
	Amit Langote <amitlangote09@gmail.com>,
	Justin Pryzby <pryzby@telsasoft.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>,
	Simon Riggs <simon.riggs@enterprisedb.com>,
	Pavan Deolasee <pavan.deolasee@gmail.com>
Subject: Re: support for MERGE
Message-ID: <202111152244.7ja4ihufwiqk@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211113225836.GM17618@telsasoft.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202111152244.7ja4ihufwiqk%40alvherre.pgsql>
Precedence: bulk

Thanks everyone for the feedback.  I attach a version with the fixes
that were submitted, as well as some additional changes:

- I removed the restriction for tables inheritance and added the sample
  I showed to regression.

- I added DO NOTHING support to the WHERE MATCHED case; it previously
  only covered WHERE NOT MATCHED.

I was thinking earlier that it may be possible to clean up the
parse_merge.c code by using another RangeTblRef to process the data
source RTE.  Haven't tried yet.

This stuff is all in
https://github.com/alvherre/postgres/commits/merge-15

-- 
Álvaro Herrera           39°49'30"S 73°17'W  —  https://www.EnterpriseDB.com/
"Nunca confiaré en un traidor.  Ni siquiera si el traidor lo he creado yo"
(Barón Vladimir Harkonnen)