Date: Wed, 1 Dec 2021 23:17:34 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: GUC flags
Message-ID: <20211202051734.GN17618@telsasoft.com>
References: <20211129030833.GJ17618@telsasoft.com>
 <YaSJcceKORqKS+cM@paquier.xyz>
 <YaXGfc+tRYFFN+bo@paquier.xyz>
 <20211201075904.GW17618@telsasoft.com>
 <YadjSDYGxYEO5k/R@paquier.xyz>
 <20211202033439.GL17618@telsasoft.com>
 <YahVin9880J9W45Z@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YahVin9880J9W45Z@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20211202051734.GN17618%40telsasoft.com>
Precedence: bulk

On Thu, Dec 02, 2021 at 02:11:38PM +0900, Michael Paquier wrote:
> On Wed, Dec 01, 2021 at 09:34:39PM -0600, Justin Pryzby wrote:
> >> @@ -2762,7 +2763,8 @@ static struct config_int ConfigureNamesInt[] =
> >>  		{"pre_auth_delay", PGC_SIGHUP, DEVELOPER_OPTIONS,
> >> -			gettext_noop("Waits N seconds on connection startup before authentication."),
> >> +			gettext_noop("Sets the amount of time to wait on connection "
> >> +						 "startup before authentication."),
> >>  			gettext_noop("This allows attaching a debugger to the process."),
> > 
> > I wonder if these should say "Sets the amount of time to wait [before]
> > authentication during connection startup"
> 
> Hmm.  I don't see much a difference between both of wordings in this
> context.

I find it easier to read "wait before authentication ..." than "wait ... before
authentication".

> > BTW the EXPLAIN flag for enable_incremental_sort could be backpatched to v13.
> 
> This could cause small diffs in EXPLAIN outputs, which could be
> surprising.  This is not worth taking any risks.

Only if one specifies explain(SETTINGS).
It's fine either way ;)

-- 
Justin