Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msrYA-0007pF-VU for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Dec 2021 19:15:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1msrY9-0004kY-0c for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Dec 2021 19:15:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msrY7-0004kP-Qj for pgsql-hackers@lists.postgresql.org; Thu, 02 Dec 2021 19:15:20 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msrXz-0007mW-Ow for pgsql-hackers@postgresql.org; Thu, 02 Dec 2021 19:15:19 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 6E9743201EA5; Thu, 2 Dec 2021 14:15:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 02 Dec 2021 14:15:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=BeJslfjqZRB/K7fTm4Cc4xCX9xpOm8Dvk6AjGoXIY7Q=; b=farPgAlf PKhpmz/cuB9coZ/OFU6TWYzrfnV85nKMY1e2jdisY7X1g/5/xrXFY6Bf0wo8kFMS OfhG/w4FWmp8RaCC+8ORBO0/IcX4mlW2ZzIOG6ciyuQpSWCLpBmOuj9Pb5HOPVuL 1sCOSdl0l9osQZlF3mOr3eXIUT6AckVsbH0ht2OwVnEnrRw22yazwkUxP8bwoxe/ iYpZFPffrblTzbhR6EWd4+rHWDCOkuZMfCCQKBGPup2ynof3+It+xe1ShrXE2ASE Pm+V110TbC0bgO3fBw6CFmkibotVHqXotj3EU3g7ob5t9P4g88LHX+p5rIZetmw0 DIMaEzQq921wqg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrieehgdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpedujeevjeffjeevuddutedvkeeiueeitddvieelfeekveej udefgeeuvdejhfeuleenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhh vghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Dec 2021 14:15:06 -0500 (EST) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 58A7C2A0742; Thu, 2 Dec 2021 16:15:03 -0300 (-03) Date: Thu, 2 Dec 2021 16:15:03 -0300 From: Alvaro Herrera To: Peter Smith Cc: Rahila Syed , Amit Kapila , Tomas Vondra , PostgreSQL-development Subject: Re: Column Filtering in Logical Replication Message-ID: <202112021915.ng4tmn2bpvrm@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2021-Sep-16, Peter Smith wrote: > I noticed that the latest v5 no longer includes the TAP test which was > in the v4 patch. > > (src/test/subscription/t/021_column_filter.pl) > > Was that omission deliberate? Somehow I not only failed to notice the omission, but also your email where you told us about it. I have since posted a version of the patch that again includes it. Thanks! -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "No renuncies a nada. No te aferres a nada."