public inbox for [email protected]  

help / color / mirror / Atom feed

From: Alvaro Herrera <[email protected]>
To: Rahila Syed <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Column Filtering in Logical Replication
Date: Fri, 10 Dec 2021 17:02:08 -0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 2021-Sep-02, Alvaro Herrera wrote:

> On 2021-Sep-02, Rahila Syed wrote:
> 
> > After thinking about this, I think it is best to remove the entire table
> > from publication,
> > if a column specified in the column filter is dropped from the table.
> 
> Hmm, I think it would be cleanest to give responsibility to the user: if
> the column to be dropped is in the filter, then raise an error, aborting
> the drop.  Then it is up to them to figure out what to do.

I thought about this some more and realized that our earlier conclusions
were wrong or at least inconvenient.  I think that the best behavior if
you drop a column from a table is to remove the column from the
publication column list, and do nothing else.

Consider the case where you add a table to a publication without a
column filter, and later drop the column.  You don't get an error that
the relation is part of a publication; simply, the subscribers of that
publication will no longer receive that column.

Similarly for this case: if you add a table to a publication with a
column list, and later drop a column in that list, then you shouldn't
get an error either.  Simply the subscribers of that publication should
receive one column less.

Should be fairly quick to implement ... on it now.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"The problem with the facetime model is not just that it's demoralizing, but
that the people pretending to work interrupt the ones actually working."
                                                           (Paul Graham)

view thread (167+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Column Filtering in Logical Replication
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox