public inbox for [email protected]  

help / color / mirror / Atom feed

From: Justin Pryzby <[email protected]>
To: Tomas Vondra <[email protected]>
Cc: Zhihong Yu <[email protected]>
Cc: Jaime Casanova <[email protected]>
Cc: [email protected]
Subject: Re: extended stats on partitioned tables
Date: Sun, 12 Dec 2021 15:49:15 -0600
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <20211007202646.GA9522@ahch-to>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CALNJ-vQSpBxw-gjZ--p-vo_yr2yHaXXOn_g8i=DQam_aAW3GwQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On Sun, Dec 12, 2021 at 10:29:39PM +0100, Tomas Vondra wrote:
> On 12/12/21 18:52, Justin Pryzby wrote:
> That's mostly a conscious choice, so that I don't have to include
> parsetree.h. But maybe that'd be better ...
> 
> > The regression tests changed as a result of not populating stx_data; I think
> > it's may be better to update like this:
> > 
> > SELECT stxname, stxdndistinct, stxddependencies, stxdmcv, stxoid IS NULL
> >   FROM pg_statistic_ext s LEFT JOIN pg_statistic_ext_data d
> >   ON d.stxoid = s.oid
> >   WHERE s.stxname = 'ab1_a_b_stats';
> > 
> 
> Not sure I understand. Why would this be better than inner join?

It shows that there's an entry in pg_statistic_ext and not one in ext_data,
rather than that it's not in at least one of the catalogs.  Which is nice to
show since as you say it's no longer 1:1.

> Thanks, fixed. Can you read through the commit messages and check the
> attribution is correct for all the patches?

Seems fine.

-- 
Justin

view thread (33+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: extended stats on partitioned tables
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox