public inbox for [email protected]  

help / color / mirror / Atom feed

From: Justin Pryzby <[email protected]>
To: Tomas Vondra <[email protected]>
Cc: Zhihong Yu <[email protected]>
Cc: Jaime Casanova <[email protected]>
Cc: [email protected]
Subject: Re: extended stats on partitioned tables
Date: Mon, 13 Dec 2021 07:48:30 -0600
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <20211007202646.GA9522@ahch-to>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CALNJ-vQSpBxw-gjZ--p-vo_yr2yHaXXOn_g8i=DQam_aAW3GwQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On Sun, Dec 12, 2021 at 10:29:39PM +0100, Tomas Vondra wrote:
> > In your 0003 patch, the "if inh: break" isn't removed from examine_variable(),
> > but the corresponding thing is removed everywhere else.
> 
> Ah, you're right. And it wasn't updated in the 0002 patch either - it
> should do the relkind check too, to allow partitioned tables. Fixed.

I think you fixed it in 0002 (thanks) but still wasn't removed from 0003?

In these comments:
+        * When dealing with regular inheritance trees, ignore extended stats
+        * (which were built without data from child rels, and thus do not
+        * represent them). For partitioned tables data from partitions are
+        * in the stats (and there's no data in the non-leaf relations), so
+        * in this case we do consider extended stats.

I suggest to add a comment after "For partitioned tables".

-- 
Justin

view thread (33+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: extended stats on partitioned tables
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox