Date: Mon, 13 Dec 2021 22:14:49 -0800
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Rewriting the test of pg_upgrade as a TAP test - take three -
 remastered set
Message-ID: <20211214061449.ynrygtcddn3ujunn@alap3.anarazel.de>
References: <e3d251fc-b3b1-d254-2b4f-70a6dcce5b29@dunslane.net>
 <YKMcbKePfS6BHKXz@paquier.xyz>
 <YKX8vOWo9iov7BJw@paquier.xyz>
 <YVaohuWPb3oDl4nn@paquier.xyz>
 <b8293b8c-2814-723c-5fdb-4496f3983cf8@dunslane.net>
 <3715954.1633208613@sss.pgh.pa.us>
 <0f70fc0f-c51a-7a58-7e12-c702352eb076@dunslane.net>
 <3735235.1633232078@sss.pgh.pa.us>
 <20211214020824.azjrighbeucby5yc@alap3.anarazel.de>
 <YbgsLG0q4n9f0JBE@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YbgsLG0q4n9f0JBE@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/20211214061449.ynrygtcddn3ujunn%40alap3.anarazel.de>
Precedence: bulk

On 2021-12-14 14:31:24 +0900, Michael Paquier wrote:
> On Mon, Dec 13, 2021 at 06:08:24PM -0800, Andres Freund wrote:
> > Seems like we might get away with making make -C contrib/pg_upgrade check and
> > vcregress.pl upgradecheck do nothing?
> 
> You mean #contrib/#src/bin/# here, right?  I don't think that we have
> any need to have "make -C" do nothing.  For vcregress.pl, we should
> IMO just remove upgradecheck.

Tom's point was that the buildfarm scripts do
	if ($self->{bfconf}->{using_msvc})
		@checklog = run_log("perl vcregress.pl upgradecheck");
	else
			  "cd $self->{pgsql}/src/bin/pg_upgrade && $make $instflags check";

if we don't want to break every buildfarm member that has TestUpgrade enabled
the moment this is committed, we need to have a backward compat path.

Greetings,

Andres Freund