public inbox for [email protected]
help / color / mirror / Atom feedFrom: Kyotaro Horiguchi <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: Re: more descriptive message for process termination due to max_slot_wal_keep_size
Date: Wed, 15 Dec 2021 13:12:18 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAExHW5spqUbAzqgZD3E3+4Gz7pE2HDeXrY1BG5KGpdHeWr0_6g@mail.gmail.com>
References: <[email protected]>
<CAExHW5spqUbAzqgZD3E3+4Gz7pE2HDeXrY1BG5KGpdHeWr0_6g@mail.gmail.com>
At Tue, 14 Dec 2021 19:31:21 +0530, Ashutosh Bapat <[email protected]> wrote in
> On Tue, Dec 14, 2021 at 9:35 AM Kyotaro Horiguchi
> <[email protected]> wrote:
> > > [17605] LOG: terminating process 17614 to release replication slot "s1"
> > + [17605] DETAIL: The slot's restart_lsn 0/2C0000A0 exceeds max_slot_wal_keep_size.
> > > [17614] FATAL: terminating connection due to administrator command
> > > [17605] LOG: invalidating slot "s1" because its restart_lsn 0/2C0000A0 exceeds max_slot_wal_keep_size
> >
> > Somewhat the second and fourth lines look inconsistent each other but
> > that wouldn't be such a problem. I don't think we want to concatenate
> > the two lines together as the result is a bit too long.
> >
> > > LOG: terminating process 17614 to release replication slot "s1" because it's restart_lsn 0/2C0000A0 exceeds max_slot_wal_keep_size.
> >
> > What do you think about this?
>
> Agree. I think we should also specify the restart_lsn value which
> would be within max_slot_wal_keep_size for better understanding.
Thanks! It seems to me the main message of the "invalidating" log has
no room for further detail. So I split the reason out to DETAILS line
the same way with the "terminating" message in the attached second
patch. (It is separated from the first patch just for review) I
believe someone can make the DETAIL message simpler or more natural.
The attached patch set emits the following message.
> LOG: invalidating slot "s1"
> DETAIL: The slot's restart_lsn 0/10000D68 is behind the limit 0/11000000 defined by max_slot_wal_keep_size.
The second line could be changed like the following or anything other.
> DETAIL: The slot's restart_lsn 0/10000D68 got behind the limit 0/11000000 determined by max_slot_wal_keep_size.
.....
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
view thread (23+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: more descriptive message for process termination due to max_slot_wal_keep_size
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox