Date: Wed, 15 Dec 2021 08:42:45 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org,
	Thomas Munro <thomas.munro@gmail.com>,
	Andrew Dunstan <andrew@dunslane.net>,
	Melanie Plageman <melanieplageman@gmail.com>
Subject: Re: Adding CI to our tree
Message-ID: <20211215144245.GS17618@telsasoft.com>
References: <20211001222752.wrz7erzh4cajvgp6@alap3.anarazel.de>
 <20211213211223.vkgg3wwiss2tragj@alap3.anarazel.de>
 <20211213220250.GH17618@telsasoft.com>
 <20211213224720.w24etz46zu6mn3er@alap3.anarazel.de>
 <189634.1639437292@sss.pgh.pa.us>
 <20211213234523.uckfzrv6zqok3hjr@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211213234523.uckfzrv6zqok3hjr@alap3.anarazel.de>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20211215144245.GS17618%40telsasoft.com>
Precedence: bulk

On Mon, Dec 13, 2021 at 03:45:23PM -0800, Andres Freund wrote:
> Hi,
> 
> On 2021-12-13 18:14:52 -0500, Tom Lane wrote:
> > Andres Freund <andres@anarazel.de> writes:
> > > On 2021-12-13 16:02:50 -0600, Justin Pryzby wrote:
> > >> sudo is used exactly twice; maybe it's not needed at all ?
> >
> > > The macos one is needed, but the freebsd one indeed isn't.
> >
> > I'm with Justin on this one.  I would view a script trying to
> > mess with /cores as a hostile act.  PG cores on macOS tend to
> > be extremely large and can fill up your disk fairly quickly
> > if you don't know they're being accumulated.  I think it's okay
> > to suggest in the documentation that people might want to allow
> > cores to be dropped, but the script has NO business trying to
> > force that.
> 
> I'm not quite following. This is a ephemeral CI instance?

As for myself, all I meant is that it's better to write it with zero sudos than
one (for the same reason that it's better to write with one than with two).

-- 
Justin