Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mxiqJ-0000wi-ST for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Dec 2021 04:58:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mxiqI-0000N5-OZ for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Dec 2021 04:58:10 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mxiqI-0000Ke-Ef for pgsql-hackers@lists.postgresql.org; Thu, 16 Dec 2021 04:58:10 +0000 Received: from mail-io1-xd34.google.com ([2607:f8b0:4864:20::d34]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mxiqF-00071n-Ud for pgsql-hackers@lists.postgresql.org; Thu, 16 Dec 2021 04:58:10 +0000 Received: by mail-io1-xd34.google.com with SMTP id x10so33555504ioj.9 for ; Wed, 15 Dec 2021 20:58:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZJglG6JZAci78KwMt5kmNUr9DvHx04JIwesMF5kU3n8=; b=xhdA28lfSzDzgnMzKdl0BVP8YB/8MT5Dn5xuWUkuv/BSTad4P5L+Kj3pA/hMW1l7/Y 4AbyyUncEWduOaMLCdFosPZUJu8QXo9URE6nCZOhs4+b3tjgexkR2Rx4y/BkYfXdxvwR 92j1g96Kng02N2CatQmcOL7apFNxT0APureQdKWEdUDfDWyJ/wxC/ezqbLpQ8Nn5nU4G x3Al1QZmpsCeGEzoKhJtX7cWFKZweBXRAVq9s0la7cPB9vHkRrUIa3uAqucepoW6H8qA KUc/620LJU3HCtJp2whW2yWq+KBNHJSeRPNJlgXq2n1kGtZwhSpD4g18NCZTxNPIASsX lSow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZJglG6JZAci78KwMt5kmNUr9DvHx04JIwesMF5kU3n8=; b=r3PPcRAzGnOXW9makbHIJBohDvYOXT3oP8E86Ecc/727voPHscTyXOkngZAWdihRU6 /hgnn3wgO6BVIW1lnp+2tHC92DRmwDB/eVciLWZ3aOHz9xSDFITKPMYsa3sYHKqXASSd h+nU80pG0NBLB0VuQPs+9oqQ6Pi8oYnLhpFwGiM7JGtexNHVuVLJHM+xeL1TCyOcV+pG /VoOSd+zpNccQ26ABYKRMWnfx43rbD2Q8yd7eRGDTq2VfxCcddGTglFE8BQ/JbXPD2od 8ThVhpWwgPiijo94l1cYjDwD30WgAwBZ1R9pCBmzZtfaYKHMg6EcXRUzyxLD7Pi7sxu6 JR1w== X-Gm-Message-State: AOAM530IwsiQc29nUnW9dEgyT28CCFBNm3ke9anF6ggnmu5uN/TBpcY2 fhKL7HaDZq3JmCN0wcSkNG07Rg== X-Google-Smtp-Source: ABdhPJzBuwZZUs9GbBIVntVUvuYNsHnt+G+xhcrQ1arryfOTR2gHnLvPKfVtxjm7/bUEQ3qlSOdViQ== X-Received: by 2002:a05:6602:4c:: with SMTP id z12mr8387894ioz.117.1639630686171; Wed, 15 Dec 2021 20:58:06 -0800 (PST) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id x2sm2079643iom.46.2021.12.15.20.58.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Dec 2021 20:58:05 -0800 (PST) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id E3B17800B45; Wed, 15 Dec 2021 22:58:04 -0600 (CST) Date: Wed, 15 Dec 2021 22:58:04 -0600 From: Justin Pryzby To: Tom Lane Cc: Peter Eisentraut , Andrew Dunstan , Andres Freund , Robert Haas , Bruce Momjian , Alvaro Herrera , pgsql-hackers@lists.postgresql.org Subject: Re: pg_dump versus ancient server versions Message-ID: <20211216045804.GZ17618@telsasoft.com> References: <20211202221607.xovsdnoh5tpbnhbs@alap3.anarazel.de> <196b40be-c571-e77f-3335-920f8a00047f@enterprisedb.com> <2316211.1638556231@sss.pgh.pa.us> <2978297.1638751274@sss.pgh.pa.us> <3794414.1639072240@sss.pgh.pa.us> <6f92dea3-9619-be68-239f-8990a832b453@dunslane.net> <70194.1639290264@sss.pgh.pa.us> <556122.1639520324@sss.pgh.pa.us> <20211216040807.GY17618@telsasoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211216040807.GY17618@telsasoft.com> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Dec 15, 2021 at 10:08:07PM -0600, Justin Pryzby wrote: > Is it possible to clean up pg_upgrade, too ? Nevermind - I found yesterday's e469f0aaf3 after git-fetch. I think you missed a few parts though ? src/bin/pg_upgrade/function.c if (GET_MAJOR_VERSION(old_cluster.major_version) <= 900) ... if (GET_MAJOR_VERSION(old_cluster.major_version) <= 900 && strcmp(lib, "$libdir/plpython") == 0) src/bin/pg_upgrade/option.c * Someday, the port number option could be removed and passed * using -o/-O, but that requires postmaster -C to be * supported on all old/new versions (added in PG 9.2). ... if (GET_MAJOR_VERSION(cluster->major_version) >= 901)