Date: Fri, 17 Dec 2021 14:03:09 +0900 (JST)
Message-Id: <20211217.140309.1173685089580065514.horikyota.ntt@gmail.com>
To: osumi.takamichi@fujitsu.com
Cc: vignesh21@gmail.com, amit.kapila16@gmail.com, sawada.mshk@gmail.com,
 gregn4422@gmail.com, houzj.fnst@fujitsu.com,
 pgsql-hackers@lists.postgresql.org
Subject: Re: Failed transaction statistics to measure the logical
 replication progress
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: 
 <TYCPR01MB83734A7A0596AC7ADB0DCB51ED779@TYCPR01MB8373.jpnprd01.prod.outlook.com>
References: 
 <CALDaNm0Wg8XwfqUVnBSSahOtNxGDLNOW1_tc4ikZK=tGfqje-A@mail.gmail.com>
	<TYCPR01MB8373A9B6508E44E547A98EF5ED779@TYCPR01MB8373.jpnprd01.prod.outlook.com>
	<TYCPR01MB83734A7A0596AC7ADB0DCB51ED779@TYCPR01MB8373.jpnprd01.prod.outlook.com>
User-Agent: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20211217.140309.1173685089580065514.horikyota.ntt%40gmail.com>
Precedence: bulk

At Thu, 16 Dec 2021 11:36:46 +0000, "osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com> wrote in 
> On Thursday, December 16, 2021 4:00 PM I wrote:
> > Thank you, everyone for confirming the direction.
> > I'll follow the consensus of the community and fix the patch, including other
> > comments.
> > I'll treat only the stats for apply workers.
> Hi, created a new version v17 according to the recent discussion
> with changes to address other review comments.
> 
> Kindly have a look at it.

It sends stats packets at every commit-like operation on apply
workers.  The current pgstat is so smart that it refrain from sending
stats packets at too high frequency.  We already suffer frequent stats
packets so apply workers need to bahave the same way.

That is, the new stats numbers are once accumulated locally then the
accumulated numbers are sent to stats collector by pgstat_report_stat.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center