Date: Fri, 17 Dec 2021 06:46:38 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Jakub Wartak <Jakub.Wartak@tomtom.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	tsunakawa.takay@fujitsu.com, osumi.takamichi@fujitsu.com,
	sfrost@snowman.net, masao.fujii@oss.nttdata.com,
	ashutosh.bapat.oss@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: In-placre persistance change of a relation
Message-ID: <20211217124637.GF17618@telsasoft.com>
References: <20210112.185808.926258436521829536.horikyota.ntt@gmail.com>
 <20210114.173217.1012910300445215120.horikyota.ntt@gmail.com>
 <20210325.140805.1356865766630580851.horikyota.ntt@gmail.com>
 <20210325.141503.245781197327278199.horikyota.ntt@gmail.com>
 <AM8PR07MB8248217A3AFEC0DD4D59ED83F6789@AM8PR07MB8248.eurprd07.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <AM8PR07MB8248217A3AFEC0DD4D59ED83F6789@AM8PR07MB8248.eurprd07.prod.outlook.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20211217124637.GF17618%40telsasoft.com>
Precedence: bulk

On Fri, Dec 17, 2021 at 09:10:30AM +0000, Jakub Wartak wrote:
> I'm especially worried if I didn't screw up something/forgot something related to the last one (rd->rd_smgr changes), but I'm getting "All 210 tests passed".

> As the thread didn't get a lot of traction, I've registered it into current commitfest https://commitfest.postgresql.org/36/3461/ with You as the author and in 'Ready for review' state. 
> I think it behaves as almost finished one and apparently after reading all those discussions that go back over 10years+ time span about this feature, and lot of failed effort towards wal_level=noWAL I think it would be nice to finally start getting some of that of it into the core.

The patch is failing:
http://cfbot.cputube.org/kyotaro-horiguchi.html
https://api.cirrus-ci.com/v1/artifact/task/5564333871595520/regress_diffs/src/bin/pg_upgrade/tmp_check/regress/regression.diffs

I think you ran "make check", but should run something like this:
make check-world -j8 >check-world.log 2>&1 && echo Success

-- 
Justin