Date: Fri, 17 Dec 2021 13:10:28 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Jakub Wartak <Jakub.Wartak@tomtom.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	tsunakawa.takay@fujitsu.com, osumi.takamichi@fujitsu.com,
	sfrost@snowman.net, masao.fujii@oss.nttdata.com,
	ashutosh.bapat.oss@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: In-placre persistance change of a relation
Message-ID: <20211217191028.GO17618@telsasoft.com>
References: <20210112.185808.926258436521829536.horikyota.ntt@gmail.com>
 <20210114.173217.1012910300445215120.horikyota.ntt@gmail.com>
 <20210325.140805.1356865766630580851.horikyota.ntt@gmail.com>
 <20210325.141503.245781197327278199.horikyota.ntt@gmail.com>
 <AM8PR07MB8248217A3AFEC0DD4D59ED83F6789@AM8PR07MB8248.eurprd07.prod.outlook.com>
 <20211217124637.GF17618@telsasoft.com>
 <AM8PR07MB8248F0B65717148A435A6FA6F6789@AM8PR07MB8248.eurprd07.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="COt1KesysQ0dNK/h"
Content-Disposition: inline
In-Reply-To: 
 <AM8PR07MB8248F0B65717148A435A6FA6F6789@AM8PR07MB8248.eurprd07.prod.outlook.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20211217191028.GO17618%40telsasoft.com>
Precedence: bulk


--COt1KesysQ0dNK/h
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Dec 17, 2021 at 02:33:25PM +0000, Jakub Wartak wrote:
> >  Justin wrote:
> > On Fri, Dec 17, 2021 at 09:10:30AM +0000, Jakub Wartak wrote:
> > > As the thread didn't get a lot of traction, I've registered it into current
> > commitfest
> > https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcommitf
> > est.postgresql.org%2F36%2F3461%2F&amp;data=04%7C01%7CJakub.Wartak%
> > 40tomtom.com%7Cb815e75090d44e20fd0a08d9c15b45cc%7C374f80267b544a
> > 3ab87d328fa26ec10d%7C0%7C0%7C637753420044612362%7CUnknown%7CT
> > WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV
> > CI6Mn0%3D%7C3000&amp;sdata=0BTQSVDnVPu4YpECKXXlBJT5q3Gfgv099SaC
> > NuBwiW4%3D&amp;reserved=0 with You as the author and in 'Ready for
> > review' state.
> > 
> > The patch is failing:
> [..] 
> > I think you ran "make check", but should run something like this:
> > make check-world -j8 >check-world.log 2>&1 && echo Success
> 
> Hi Justin,
> 
> I've repeated the check-world and it says to me all is ok locally (also with --enable-cassert --enable-debug , at least on Amazon Linux 2) and also installcheck on default params seems to be ok  
> I don't seem to understand why testfarm reports errors for tests like "path, polygon, rowsecurity" e.g. on Linux/graviton2 and FreeBSD while not on MacOS(?) . 
> Could someone point to me where to start looking/fixing?

Since it says this, it looks a lot like a memory error like a use-after-free
 - like in fsync_parent_path():

 CREATE TABLE PATH_TBL (f1 path);
+ERROR:  could not open file <....>  Pacific": No such file or directory

I see at least this one is still failing, though:
time make -C src/test/recovery check

--COt1KesysQ0dNK/h
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-In-place-table-persistence-change-with-new-command-A.patch"