Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mzEPK-0004Cb-0K for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Dec 2021 08:52:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mzEPI-0008K6-Om for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Dec 2021 08:52:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mzEPI-0008Jx-Du for pgsql-hackers@lists.postgresql.org; Mon, 20 Dec 2021 08:52:32 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mzEPC-0001Zf-4q for pgsql-hackers@lists.postgresql.org; Mon, 20 Dec 2021 08:52:32 +0000 Received: by mail-pj1-x1031.google.com with SMTP id iy13so3235874pjb.5 for ; Mon, 20 Dec 2021 00:52:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:message-id:to:cc:subject:from:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=JixjnWCXqS7EIeY58hgRyOAhNiXmWVYqX4IvRz6om/g=; b=pU8Q/Uqw89KHIVbviNxFtlOeWQ1vctRC8xrTZoBxRIiVbFiTXPtogMrdJOldm+bC87 mD+EajVDPXfw89g9tx113wyHnGxI0gTWmHpgghaNCXrzBj0oleZo9//UqT0d22BdtlGn vWgqzQ+BV2oIHVEa2o0YeTjqDyRa1cwHLIn7T/LKbezVuLZ+/ziLU94mZbPiPsTHW3Q2 urJANmc20XljqQVVhWWFykXv+a72bYUTe+e4YZP56yYWO+MhKBcnE5bwrz7cZ+SCz1kY oi2WPOA4/y4TN16UBZFUSUjPN6X9+ILqWbE/U5ywcvuQoIaKuMMjLMM0MRu8y1tvklL9 Yh8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:to:cc:subject:from:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=JixjnWCXqS7EIeY58hgRyOAhNiXmWVYqX4IvRz6om/g=; b=gTh/Al438M/RiH3bqNenyKDFTQbKZz3N/Lwngv1jgwV79sQ4NvCBvhrRVuJawA0WZ3 OVLNenA4KoNRihpRDKt3SGgRLIAZwH1f7ECaVn9X2TPA7eBwN88k0ASi1Prsj2m8uaFL p0bE5LQp6w7R9ghBNrTPzd9ZDh0wt2u+T5IynGfbBAR+fHjfkgaB0J4TNBWapBRuc2t6 wZ8urAQFFSVLZ9NHpBxjrqEil+aC1yA3SZncdWI8gNWkSb7BC2pDE0UajSVkI/UCw9mG mgFxTMnzDm+IjX/nZIRiAKPDdnsABQpHAP+HeAhZYv1YKrJUnNLevlzPXUb1gjaYazee LiuQ== X-Gm-Message-State: AOAM530UPvYg1JsCZym938VCeXKxOYtgT4pcN8eQfyghEPolxwSIOxfW 9oqNJwSCTQeF+wDOpKOlROY= X-Google-Smtp-Source: ABdhPJw2ql3KNbgoHkPeFGBXJBoCgn1HM60Ny9+fIkGjRkT0rtBBpXD061Ar0LKax8thSRpodGP0gg== X-Received: by 2002:a17:90a:ead0:: with SMTP id ev16mr17005451pjb.197.1639990344266; Mon, 20 Dec 2021 00:52:24 -0800 (PST) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id l2sm17833189pfc.42.2021.12.20.00.52.21 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 20 Dec 2021 00:52:23 -0800 (PST) Date: Mon, 20 Dec 2021 17:52:21 +0900 (JST) Message-Id: <20211220.175221.1527785299351662712.horikyota.ntt@gmail.com> To: Jakub.Wartak@tomtom.com Cc: tsunakawa.takay@fujitsu.com, osumi.takamichi@fujitsu.com, sfrost@snowman.net, masao.fujii@oss.nttdata.com, ashutosh.bapat.oss@gmail.com, pgsql-hackers@lists.postgresql.org Subject: Re: In-placre persistance change of a relation From: Kyotaro Horiguchi In-Reply-To: <20211220.173927.2048573811665828411.horikyota.ntt@gmail.com> References: <20211220.152823.1386247767464518843.horikyota.ntt@gmail.com> <20211220.173927.2048573811665828411.horikyota.ntt@gmail.com> User-Agent: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk At Mon, 20 Dec 2021 17:39:27 +0900 (JST), Kyotaro Horiguchi wrote in > At Mon, 20 Dec 2021 07:59:29 +0000, Jakub Wartak wrote in > > BTW fast feedback regarding that ALTER patch (there were 4 unlogged tables): > > # ALTER TABLE ALL IN TABLESPACE tbs1 set logged; > > WARNING: unrecognized node type: 349 > > lol I met a server crash. Will fix. Thanks! That crash vanished after a recompilation for me and I don't see that error. On my dev env node# 349 is T_ALterTableSetLoggedAllStmt, which 0002 adds. So perhaps make clean/make all would fix that. regards. -- Kyotaro Horiguchi NTT Open Source Software Center