Date: Fri, 24 Dec 2021 17:30:16 +0900 (JST)
Message-Id: <20211224.173016.2237752923975758130.horikyota.ntt@gmail.com>
To: sawada.mshk@gmail.com
Cc: ashutosh.bapat.oss@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: more descriptive message for process termination due to
 max_slot_wal_keep_size
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: 
 <CAD21AoDaddEEdqx945T29+=MzEiz1rMvj9568p5jNSvHw1sTDQ@mail.gmail.com>
References: 
 <CAExHW5vX7B84LBCzT_rO+CLjt1xeqCfs3AfBEttbxaCMMpAXzQ@mail.gmail.com>
	<20211224.134214.1646603596386019768.horikyota.ntt@gmail.com>
	<CAD21AoDaddEEdqx945T29+=MzEiz1rMvj9568p5jNSvHw1sTDQ@mail.gmail.com>
User-Agent: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20211224.173016.2237752923975758130.horikyota.ntt%40gmail.com>
Precedence: bulk

Thank you for the comment.

At Fri, 24 Dec 2021 17:06:57 +0900, Masahiko Sawada <sawada.mshk@gmail.com> wrote in 
> Thank you for the patch! +1 for improving the messages.
> 
> >
> > > LOG:  terminating process %d to release replication slot \"%s\" because its restart_lsn %X/%X exceeds max_slot_wal_keep_size
> > > DETAIL:  The slot got behind the limit %X/%X determined by max_slot_wal_keep_size.
> >
> > > LOG:  invalidating slot \"%s\" because its restart_LSN %X/%X exceeds max_slot_wal_keep_size
> > c> DETAIL:  The slot got behind the limit %X/%X determined by max_slot_wal_keep_size.
> 
> -
> LSN_FORMAT_ARGS(restart_lsn))));
> +
> LSN_FORMAT_ARGS(restart_lsn)),
> +                                                errdetail("The slot
> got behind the limit %X/%X determined by max_slot_wal_keep_size.",
> +
> LSN_FORMAT_ARGS(oldestLSN))));
> 
> Isn't oldestLSN calculated not only by max_slot_wal_keep_size but also
> by wal_keep_size?

Right. But I believe the two are not assumed to be used at once. One
can set wal_keep_size larger than max_slot_wal_keep_size but it is
actually a kind of ill setting.

LOG:  terminating process %d to release replication slot \"%s\" because its restart_lsn %X/%X exceeds max_slot_wal_keep_size
DETAIL:  The slot got behind the limit %X/%X determined by max_slot_wal_keep_size and wal_keep_size.

Mmm. I don't like this.  I feel we don't need such detail in the
message..  I'd like to hear opinions from others, please.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center