Date: Wed, 29 Dec 2021 07:59:16 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Ronan Dunklau <ronan.dunklau@aiven.io>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Proposal: More structured logging
Message-ID: <20211229135916.GN24477@telsasoft.com>
References: <202108191304.u7g5wwuepwpe@alvherre.pgsql>
 <1745789.A5U81WbCk6@aivenronan>
 <3358218.yRJqF8fxcQ@aivenronan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3358218.yRJqF8fxcQ@aivenronan>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20211229135916.GN24477%40telsasoft.com>
Precedence: bulk

> Subject: [PATCH v3 2/3] Add test module for the new tag functionality.
...
> +test_logging(PG_FUNCTION_ARGS)
> +{
...
> +	 (errmsg("%s", message),
> +	  ({
> +		forboth(lk, keys, lv, values)
> +		{
> +			(errtag(lfirst(lk), "%s", (char *) lfirst(lv)));
> +		}})
> +	));

The windows build fails with that syntax.
http://cfbot.cputube.org/ronan-dunklau.html
https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.157923

> Subject: [PATCH v3 3/3] Output error tags in CSV logs
> +++ b/doc/src/sgml/config.sgml
> @@ -7370,6 +7371,7 @@ CREATE TABLE postgres_log
>    backend_type text,
>    leader_pid integer,
>    query_id bigint,
> +  tags jsonb
>    PRIMARY KEY (session_id, session_line_num)
>  );
>  </programlisting>

That's invalid sql due to missing a trailing ",".

You should also update file-fdw.sgml - which I only think of since we forgot in
to update it before e568ed0eb and 0830d21f5.  config.sgml should have a comment
as a reminder to do that.

-- 
Justin