Date: Wed, 29 Dec 2021 11:51:21 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: "Imseih (AWS), Sami" <simseih@amazon.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
	"Bossart, Nathan" <bossartn@amazon.com>,
	pgsql-hackers@postgresql.org
Subject: Re: Add index scan progress to pg_stat_progress_vacuum
Message-ID: <20211229175121.GP24477@telsasoft.com>
References: <5478DFCD-2333-401A-B2F0-0D186AB09228@amazon.com>
 <7874FB21-FAA5-49BD-8386-2866552656C7@amazon.com>
 <CAH2-Wzmz4Z+UYqRgYHuyxYHha4Gn-aBprydmG0n+m6J2J_ABSA@mail.gmail.com>
 <CAD21AoCKOFjU8XpPjXgfNrP3-V71AL5NKY+3or7eeRnNMKqi0g@mail.gmail.com>
 <7F1C93C1-C50E-497A-86C5-B637EA4D9F79@amazon.com>
 <04D9F80C-1A7C-4C23-9156-6799D974DC72@amazon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <04D9F80C-1A7C-4C23-9156-6799D974DC72@amazon.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20211229175121.GP24477%40telsasoft.com>
Precedence: bulk

http://cfbot.cputube.org/sami-imseih.html
You should run "make check" and update rules.out.

You should also use make check-world - usually something like:
make check-world -j4 >check-world.out 2>&1 ; echo ret $?

> indrelid: The relid of the index currently being vacuumed

I think it should be called indexrelid not indrelid, for consistency with
pg_index.

> S.param10 vacuum_cycle_ordinal_position,
> S.param13 index_rows_vacuumed

These should both say "AS" for consistency.

system_views.sql is using tabs, but should use spaces for consistency.

> #include "commands/progress.h"

The postgres convention is to alphabetize the includes.

>       /* VACCUM operation's longest index scan cycle */

VACCUM => VACUUM

Ultimately you'll also need to update the docs.