Date: Thu, 30 Dec 2021 20:32:29 -0300
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	"houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
	Rahila Syed <rahilasyed90@gmail.com>,
	Peter Smith <smithpb2250@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: Column Filtering in Logical Replication
Message-ID: <202112302332.3dficrkfzcyt@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="c73af22q7iivrqkd"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211230221634.GT24477@telsasoft.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202112302332.3dficrkfzcyt%40alvherre.pgsql>
Precedence: bulk


--c73af22q7iivrqkd
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On 2021-Dec-30, Justin Pryzby wrote:

Thank you!  I've incorporated your proposed fixes.

> > +		/*
> > +		 * Even if the user listed all columns in the column list, we cannot
> > +		 * allow a column list to be specified when REPLICA IDENTITY is FULL;
> > +		 * that would cause problems if a new column is added later, because
> > +		 * that could would have to be included (because of being part of the
> 
> could would is wrong

Hah, yeah, this was "that column would".

> > + * Gets a list of OIDs of all column-partial publications of the given
> > + * relation, that is, those that specify a column list.
> 
> I would call this a "partial-column" publication.

OK, done that way.

-- 
Álvaro Herrera              Valdivia, Chile  —  https://www.EnterpriseDB.com/

--c73af22q7iivrqkd
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="v14-0001-Avoid-use-of-DEFELEM-enum-in-AlterPublicationStm.patch"