Date: Fri, 31 Dec 2021 10:32:27 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	"houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
	Rahila Syed <rahilasyed90@gmail.com>,
	Peter Smith <smithpb2250@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: Column Filtering in Logical Replication
Message-ID: <20211231163227.GV24477@telsasoft.com>
References: <20211230221634.GT24477@telsasoft.com>
 <202112302332.3dficrkfzcyt@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202112302332.3dficrkfzcyt@alvherre.pgsql>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20211231163227.GV24477%40telsasoft.com>
Precedence: bulk

> @@ -5963,8 +5967,20 @@ describePublications(const char *pattern)
>  		{
>  			/* Get the tables for the specified publication */
>  			printfPQExpBuffer(&buf,
> -							  "SELECT n.nspname, c.relname\n"
> -							  "FROM pg_catalog.pg_class c,\n"
> +							  "SELECT n.nspname, c.relname, \n");
> +			if (pset.sversion >= 150000)
> +				appendPQExpBufferStr(&buf,
> +									 "       CASE WHEN pr.prattrs IS NOT NULL THEN\n"
> +									 "       pg_catalog.array_to_string"
> +									 "(ARRAY(SELECT attname\n"
> +									 "         FROM pg_catalog.generate_series(0, pg_catalog.array_upper(pr.prattrs::int[], 1)) s,\n"
> +									 "              pg_catalog.pg_attribute\n"
> +									 "        WHERE attrelid = c.oid AND attnum = prattrs[s]), ', ')\n"
> +									 "       ELSE NULL END AS columns");
> +			else
> +				appendPQExpBufferStr(&buf, "NULL as columns");
> +			appendPQExpBuffer(&buf,
> +							  "\nFROM pg_catalog.pg_class c,\n"
>  							  "     pg_catalog.pg_namespace n,\n"
>  							  "     pg_catalog.pg_publication_rel pr\n"
>  							  "WHERE c.relnamespace = n.oid\n"

I suppose this should use pr.prattrs::pg_catalog.int2[] ?

Did the DatumGetBool issue expose a deficiency in testing ?
I think the !am_partition path was never being hit.

-- 
Justin