Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oRg0A-00055o-La
	for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Aug 2022 20:32:26 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oRg08-0000zG-MC
	for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Aug 2022 20:32:24 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oRg08-0000z6-DF
	for pgsql-hackers@lists.postgresql.org; Fri, 26 Aug 2022 20:32:24 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oRg05-0006ZA-Rk; Fri, 26 Aug 2022 20:32:23 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 27QKWFmq2021464;
	Fri, 26 Aug 2022 16:32:15 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: John Naylor <john.naylor@enterprisedb.com>,
        Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= <ilmari@ilmari.org>,
        Justin Pryzby <pryzby@telsasoft.com>,
        John Naylor <john.naylor@postgresql.org>,
        pgsql-hackers <pgsql-hackers@postgresql.org>,
        Thomas Munro <thomas.munro@gmail.com>
Subject: Re: windows cfbot failing: my_perl
In-reply-to: <20220826202830.26fn67xocpryulrj@awork3.anarazel.de>
References: <20220826115546.GE2342@telsasoft.com>
 <20220826132151.sj6pieswskq4vp4z@awork3.anarazel.de>
 <20220826134047.vr3bppkwqhy5ppn3@awork3.anarazel.de>
 <20220826142700.fecymkdgdelktrlp@awork3.anarazel.de>
 <CAFBsxsFew_-eaa6geJsR5WcRLeQ9afrPg4rZL59g=3GGu5g_+Q@mail.gmail.com>
 <20220826144740.ff3berqoeoi6lnd4@awork3.anarazel.de>
 <20220826202830.26fn67xocpryulrj@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Fri, 26 Aug 2022 13:28:30 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2021462.1661545935.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 26 Aug 2022 16:32:15 -0400
Message-ID: <2021463.1661545935@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/2021463.1661545935%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> Tom, Ilmari, you seem to have hacked on this stuff most (not so) recentl=
y. Do
> you have a better suggestion than moving the mb/pg_wchar.h include out o=
f
> plperl_helpers.h as I suggest below?

I agree with the conclusion that we'd better #include all our own
headers before any of Perl's.  No strong opinions about which
rearrangement is least ugly --- but let's add some comments about
that requirement.

			regards, tom lane