Date: Sun, 2 Jan 2022 13:34:45 -0800
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Sehrope Sarkuni <sehrope@jackdb.com>,
	Pg Hackers <pgsql-hackers@postgresql.org>, david@fetter.org
Subject: Re: Add jsonlog log_destination for JSON server logs
Message-ID: <20220102213445.ehlrwmzeljthcgci@alap3.anarazel.de>
References: <YUA78XrG3l7eVY4h@paquier.xyz>
 <CAH7T-apxdwf7=CHD_Vuo+QgtV6TEnLc0N0_SMTJ-a-jFdOBOvA@mail.gmail.com>
 <YUPxBNUOYpDgOZol@paquier.xyz>
 <CAH7T-aqkmrCEpTqvwUOWNATitWCnPPf3M75+af8c4afMEbMepQ@mail.gmail.com>
 <YVKMQkIVoK7DbmHM@paquier.xyz>
 <YVPJIuSeUujhhHsb@paquier.xyz>
 <YVv8OYe1Bb5GHf5f@paquier.xyz>
 <YV+6+ur5kG/QsJjn@paquier.xyz>
 <YW6lqsGieUn2IhKB@paquier.xyz>
 <YYvM0YP2ujKy6uFy@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YYvM0YP2ujKy6uFy@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/20220102213445.ehlrwmzeljthcgci%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2021-11-10 22:44:49 +0900, Michael Paquier wrote:
> Patch 0003 has been heavily reworked, and it would be good to have an
> extra pair of eyes on it.  So I have switched the CF entry as "Needs
> Review" and added my name to the list of authors (originally this
> stuff took code portions of own module, as well).

The tests don't seem to pass on windows:
https://cirrus-ci.com/task/5412456754315264?logs=test_bin#L47
https://api.cirrus-ci.com/v1/artifact/task/5412456754315264/tap/src/bin/pg_ctl/tmp_check/log/regress_log_004_logrotate

psql:<stdin>:1: ERROR:  division by zero
could not open "c:/cirrus/src/bin/pg_ctl/tmp_check/t_004_logrotate_primary_data/pgdata/current_logfiles": The system cannot find the file specified at t/004_logrotate.pl line 87.

Greetings,

Andres Freund