Date: Tue, 4 Jan 2022 00:24:18 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Pavel Luzanov <p.luzanov@postgrespro.ru>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: psql: \dl+ to list large objects privileges
Message-ID: <20220104062417.GA14051@telsasoft.com>
References: <6d722115-6297-bc53-bb7f-5f150e765299@postgrespro.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6d722115-6297-bc53-bb7f-5f150e765299@postgrespro.ru>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: <https://www.postgresql.org/message-id/20220104062417.GA14051%40telsasoft.com>
Precedence: bulk

On Tue, Aug 31, 2021 at 05:14:12PM +0300, Pavel Luzanov wrote:
> I decided to move the do_lo_list function to describe.c in order to use the
> printACLColumn helper function. And at the same time I renamed do_lo_list to
> listLargeObjects to unify with the names of other similar functions.

The tabs were changed to spaces when you moved the function.

I suggest to move the function in a separate 0001 commit, which makes no code
changes other than moving from one file to another.  

A committer would probably push them as a single patch, but this makes it
easier to read and review the changes in 0002.
Possibly like git diff HEAD~:src/bin/psql/large_obj.c src/bin/psql/describe.c

> +        if (pset.sversion >= 90000)

Since a few weeks ago, psql no longer supports server versions before 9.2, so
the "if" branch can go away.

> I don't like how I handled the + modifier in the \lo_list command. But I
> don't know how to do better now. This is the second time I've programmed in
> C. The first time was the 'Hello World' program. So maybe something is done
> wrong.

I think everywhere else just uses verbose = strchr(cmd, '+') != 0;

-- 
Justin