Date: Wed, 5 Jan 2022 11:10:17 -0300
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Peter Smith <smithpb2250@gmail.com>
Cc: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
	"tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
	Euler Taveira <euler@eulerto.com>,
	Greg Nancarrow <gregn4422@gmail.com>,
	vignesh C <vignesh21@gmail.com>, Ajin Cherian <itsajin@gmail.com>,
	Dilip Kumar <dilipbalaut@gmail.com>,
	Rahila Syed <rahilasyed90@gmail.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	=?utf-8?B?w5ZuZGVyIEthbGFjxLE=?= <onderkalaci@gmail.com>,
	japin <japinli@hotmail.com>, Michael Paquier <michael@paquier.xyz>,
	David Steele <david@pgmasters.net>,
	Craig Ringer <craig@2ndquadrant.com>,
	Amit Langote <amitlangote09@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: row filtering for logical replication
Message-ID: <202201051410.za34b6zgpxvj@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHut+PvkswkGLqzYo7z9rwOoDeLtUk0PEha8kppNvZts0h22Hw@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/202201051410.za34b6zgpxvj%40alvherre.pgsql>
Precedence: bulk

BTW I think it's not great to commit with the presented split.  We would
have non-trivial short-lived changes for no good reason (0002 in
particular).  I think this whole series should be a single patch, with
the commit message being a fusion of messages explaining in full what
the functional change is, listing all the authors together.  Having a
commit message like in 0001 where all the distinct changes are explained
in separate sections with each section listing its own author, does not
sound very useful or helpful.

-- 
Álvaro Herrera              Valdivia, Chile  —  https://www.EnterpriseDB.com/
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end." (2nd Commandment for C programmers)