Date: Tue, 11 Jan 2022 20:20:27 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: Peter Geoghegan <pg@bowt.ie>, Masahiko Sawada <sawada.mshk@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	"Bossart, Nathan" <bossartn@amazon.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: do only critical work during single-user vacuum?
Message-ID: <20220112022026.GC14051@telsasoft.com>
References: <DB4D9904-146A-4B21-8362-99F885C489E1@amazon.com>
 <CAH2-Wz=Eb-jrhFK6=_WNT6V1JAK-qFOTu_4-yOpAhkEES4VeNA@mail.gmail.com>
 <20211221034630.maoteglpjqpgh62g@alap3.anarazel.de>
 <CAD21AoCz8=-jBTUBcQSveOMCLkJ=yUw5TYtfVPWKTXiLuan_CQ@mail.gmail.com>
 <CAH2-Wzn+PJ99oJRnN32ojvRpgH4xjmTOJZbt+GTHpDWN655Adg@mail.gmail.com>
 <CAD21AoAXHZ0J-Xd0RfP_VpkUnGv0G_gCbwt3aCuy6weOKNaHNw@mail.gmail.com>
 <CAFBsxsHCBWTJx5j6zKogh5-_wuggcHJT7g+5_TQVMyKvgCT4Fw@mail.gmail.com>
 <CAFBsxsE1TWidnMs=RMx1eb2QxqmNqdDaLLN5E7SP_v5_g2ZRwA@mail.gmail.com>
 <CAH2-Wzmt29ZUwXW+9ACvxMoN9AjSMuH_Oabk1_mJt78f58WdvQ@mail.gmail.com>
 <CAFBsxsEoYaGVFq+7UeW2kZzO8pCAOTUB+j5RNw-Hm-w_Xo97Xg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAFBsxsEoYaGVFq+7UeW2kZzO8pCAOTUB+j5RNw-Hm-w_Xo97Xg@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220112022026.GC14051%40telsasoft.com>
Precedence: bulk

On Tue, Jan 11, 2022 at 07:58:56PM -0500, John Naylor wrote:
> +		// FIXME: also check reloption
> +		// WIP: 95% is a starting point for discussion
> +		if ((table_xid_age < autovacuum_freeze_max_age * 0.95) ||
> +			(table_mxid_age < autovacuum_multixact_freeze_max_age * 0.95))
> +			continue;

Should be &&

Should this emergency vacuum "order by age() DESC" ?

-- 
Justin