Date: Tue, 11 Jan 2022 22:08:13 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Andrew Dunstan <andrew@dunslane.net>,
	Bruce Momjian <bruce@momjian.us>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade should truncate/remove its logs before running
Message-ID: <20220112040813.GD14051@telsasoft.com>
References: <20211217172113.GL17618@telsasoft.com>
 <YcBnT2awK89o6P5I@paquier.xyz>
 <20211221033926.GX17618@telsasoft.com>
 <YcLYAPsiDlWF6w7o@paquier.xyz>
 <238201.1640184746@sss.pgh.pa.us>
 <20211222163611.GC17618@telsasoft.com>
 <20220108184857.GI14051@telsasoft.com>
 <Yd00xmV+rdffAQxf@paquier.xyz>
 <20220111200307.GA14051@telsasoft.com>
 <Yd5SOupY+FHbiXLD@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yd5SOupY+FHbiXLD@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220112040813.GD14051%40telsasoft.com>
Precedence: bulk

On Wed, Jan 12, 2022 at 12:59:54PM +0900, Michael Paquier wrote:
> On Tue, Jan 11, 2022 at 02:03:07PM -0600, Justin Pryzby wrote:
> > There's no reason not to.  We created the dir, and the user didn't specify to
> > preserve it.  It'd be their fault if they put something valuable there after
> > starting pg_upgrade.
> 
> This is a path for the data internal to pg_upgrade.  My take is that
> the code simplifications the new option brings are more valuable than
> this assumption, which I guess would unlikely happen.  I may be wrong,
> of course.  By the way, while thinking about that, should we worry
> about --logdir="."?

I asked about that before.  Right now, it'll exit(1) when mkdir fails.

I had written a patch to allow "." by skipping mkdir (or allowing it to fail if
errno == EEXIST), but it seems like an awfully bad idea to try to make that
work with rmtree().

-- 
Justin