Date: Wed, 12 Jan 2022 18:20:55 +0800
From: Julien Rouhaud <rjuju123@gmail.com>
To: Zhihong Yu <zyu@yugabyte.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	vignesh C <vignesh21@gmail.com>
Subject: Re: dynamic result sets support in extended query protocol
Message-ID: <20220112102055.fn5gpnt2lw6ii35o@jrouhaud>
References: <6e747f98-835f-2e05-cde5-86ee444a7140@2ndquadrant.com>
 <20201009184625.4hfgpcxzd6jfredb@alap3.anarazel.de>
 <a2da2fea-b15f-5a86-c0ab-836756d9c919@2ndquadrant.com>
 <d0840629-c875-a90b-e114-a4cdc91e2255@pgmasters.net>
 <7e404216-62b5-93da-1a74-c1d5aa1fe47a@2ndquadrant.com>
 <6f038f18-0f2b-5271-a56f-1770577f246c@enterprisedb.com>
 <CALDaNm3VjrBP5-zRyasDC35B+NZD39=c-AZo0=6iDiNu31d3Pg@mail.gmail.com>
 <525d517f-72ab-9488-211b-ad3cb0aea3a3@enterprisedb.com>
 <CALNJ-vTHehDOEUTD6iBxaLhQAYvLDOrTRn0vVW+wVscy-VtUiQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALNJ-vTHehDOEUTD6iBxaLhQAYvLDOrTRn0vVW+wVscy-VtUiQ@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/20220112102055.fn5gpnt2lw6ii35o%40jrouhaud>
Precedence: bulk

Hi,

On Mon, Aug 30, 2021 at 02:11:34PM -0700, Zhihong Yu wrote:
> On Mon, Aug 30, 2021 at 1:23 PM Peter Eisentraut <
> peter.eisentraut@enterprisedb.com> wrote:
> 
> > rebased patch set
> 
> +    <term><literal>WITH RETURN</literal></term>
> +    <term><literal>WITHOUT RETURN</literal></term>
> +    <listitem>
> +     <para>
> +      This option is only valid for cursors defined inside a procedure.
> 
> Since there are two options listed, I think using 'These options are' would
> be better.
> 
> For CurrentProcedure(),
> 
> +       return InvalidOid;
> +   else
> +       return llast_oid(procedure_stack);
> 
> The word 'else' can be omitted.

The cfbot reports that the patch doesn't apply anymore:
http://cfbot.cputube.org/patch_36_2911.log.

Since you mentioned that this patch depends on the SHOW_ALL_RESULTS psql patch
which is still being worked on, I'm not expecting much activity here until the
prerequirements are done.  It also seems better to mark this patch as Waiting
on Author as further reviews are probably not really needed for now.