Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7b24-0005E8-Lj for pgsql-hackers@arkaria.postgresql.org; Wed, 12 Jan 2022 10:39:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1n7b23-0001W1-GW for pgsql-hackers@arkaria.postgresql.org; Wed, 12 Jan 2022 10:39:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7b23-0001Vs-5a for pgsql-hackers@lists.postgresql.org; Wed, 12 Jan 2022 10:39:07 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1n7b20-0006et-Hu for pgsql-hackers@lists.postgresql.org; Wed, 12 Jan 2022 10:39:06 +0000 Received: by mail-pj1-x102b.google.com with SMTP id a1-20020a17090a688100b001b3fd52338eso2825511pjd.1 for ; Wed, 12 Jan 2022 02:39:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=AF3n/hqIXI6gkYDIwbAAai5CTJoXxxAvcMCbU1A3YEI=; b=pv/EoYfXNkakX69oSXflNbhmJVy7HCLyNbz+WnwpEIDwTmgHcniwvmM89Y899CTR4H 5qEFTbaniFLMKlsZWCbmowcFlShEuQns2Slx8D/nSkl/Zc7M6DSaKw9J7Q53f0DnETbQ yjcFuFVle0+j1yqNI5S/hLp12BaJlaucJtIUUhBu0rgFqQzivvuO5+9x5tsCW9ZbkCqB D4XlVerHVfFvz42xl5ciBzWPcM/deUfTacyvuJXzy31nn8pOD9mfJeyW1fklU8Wcr6i7 PBp0jHQS8qXgoONSJ9n1dhiOoQKKhR+nckLDO2VEvciUa+DdLX1J01oxxtOVTbhWqIpR dPjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=AF3n/hqIXI6gkYDIwbAAai5CTJoXxxAvcMCbU1A3YEI=; b=V7hlQBggKfHcBT1JrzZ/+xHm6ny/MHAb062AiBdlAmJj5udohX8VmKfZZxkYqVRkrq Wul7kWh3swJ2Pvjf8z05P/A9Thng+eoDRNwoz/JyMvwtAyMn3kh5FK8reuy3cqOFpyWA gwSPU+VILjv39J+FwpD9hsqjiPiG0b1C6ep7buJBEKwB1QmLVd8GKPSo2ndmrCH3l5AE i7bN75xpSXCg1ZxUs/lMiD4rU+9Di4YzApUC2bX4kfBKFYLQYQN+vPdjbX3IxZldgRl/ 4Hytu4d2uNw7ULjngV7PKT2+ZymKySxoQkvk/2Wi5xjCBvjiQoi3Q6agEjkdBnhDZfOu /ZFA== X-Gm-Message-State: AOAM533z3hvpCmSVdF6KvKJ4ufn4qAKfVPOYmeTRS/VAgJjw5wRsVE4G aB7kZhShk0H1qCs49OPc7Tw3PEyB3doNRQ== X-Google-Smtp-Source: ABdhPJz3awBwEFFu2egMAR5HltoeP6cTYK+RG2RG4c8Dhp/zaXnj7i6mxs7FGOuOUBELfQugxql+pA== X-Received: by 2002:aa7:84c1:0:b0:4bf:379:1d85 with SMTP id x1-20020aa784c1000000b004bf03791d85mr8679936pfn.5.1641983942242; Wed, 12 Jan 2022 02:39:02 -0800 (PST) Received: from jrouhaud (1-171-174-202.dynamic-ip.hinet.net. [1.171.174.202]) by smtp.gmail.com with ESMTPSA id x29sm5004834pfh.175.2022.01.12.02.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jan 2022 02:39:00 -0800 (PST) Date: Wed, 12 Jan 2022 18:38:55 +0800 From: Julien Rouhaud To: Dilip Kumar Cc: Kyotaro Horiguchi , PostgreSQL Hackers Subject: Re: Error "initial slot snapshot too large" in create replication slot Message-ID: <20220112103855.ib4455yyebaxkuwp@jrouhaud> References: <20211011.195937.2061830189397708214.horikyota.ntt@gmail.com> <20211012.135959.877910916353346602.horikyota.ntt@gmail.com> <20211012.140538.1773596942564999382.horikyota.ntt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On Tue, Nov 02, 2021 at 04:40:39PM +0530, Dilip Kumar wrote: > > I have fixed this, the updated patch is attached. The cfbot reports that this patch doesn't compile: https://cirrus-ci.com/task/5642000073490432?logs=build [03:01:24.477] snapbuild.c: In function ‘SnapBuildInitialSnapshot’: [03:01:24.477] snapbuild.c:587:2: error: ‘newsubxcnt’ undeclared (first use in this function); did you mean ‘newsubxip’? [03:01:24.477] 587 | newsubxcnt = 0; [03:01:24.477] | ^~~~~~~~~~ [03:01:24.477] | newsubxip [03:01:24.477] snapbuild.c:587:2: note: each undeclared identifier is reported only once for each function it appears in [03:01:24.477] snapbuild.c:535:8: warning: unused variable ‘maxxidcnt’ [-Wunused-variable] [03:01:24.477] 535 | int maxxidcnt; [03:01:24.477] | ^~~~~~~~~ Could you send a new version? In the meantime I will switch the patch to Waiting on Author.