Date: Wed, 12 Jan 2022 21:44:33 -0800
From: Andres Freund <andres@anarazel.de>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: psql - add SHOW_ALL_RESULTS option
Message-ID: <20220113054433.wdjhidtm7gvyhfts@alap3.anarazel.de>
References: <18c78a01-4a34-9dd4-f78b-6860f1420c8e@enterprisedb.com>
 <alpine.DEB.2.22.394.2107221655020.25741@pseudo>
 <6954328d-96f2-77f7-735f-7ce493a40949@enterprisedb.com>
 <alpine.DEB.2.22.394.2109251058000.3216312@pseudo>
 <alpine.DEB.2.22.394.2110021622530.2817726@pseudo>
 <2570e2ae-fa0f-aac9-f72f-bb59a9983a20@enterprisedb.com>
 <alpine.DEB.2.22.394.2112230703530.2668598@pseudo>
 <46259d13-5f90-1475-3c85-d7a597a2b862@enterprisedb.com>
 <alpine.DEB.2.22.394.2201040851220.3857182@pseudo>
 <alpine.DEB.2.22.394.2201081931170.731324@pseudo>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2201081931170.731324@pseudo>
Archived-At: <https://www.postgresql.org/message-id/20220113054433.wdjhidtm7gvyhfts%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2022-01-08 19:32:36 +0100, Fabien COELHO wrote:
> Attached v13 where the crash test is moved to tap.

The reason this test constantly fails on cfbot windows is a use-after-free
bug.

I figured that out in the context of another thread, so the debugging is
there:

https://postgr.es/m/20220113054123.ib4khtafgq34lv4z%40alap3.anarazel.de
> Ah, I see the bug. It's a use-after-free introduced in the patch:
>
> SendQueryAndProcessResults(const char *query, double *pelapsed_msec,
> 	bool is_watch, const printQueryOpt *opt, FILE *printQueryFout, bool *tx_ended)
> 
> 
> ...
> 	/* first result */
> 	result = PQgetResult(pset.db);
> 
> 
> 	while (result != NULL)
> 
> 
> ...
> 		if (!AcceptResult(result, false))
> 		{
> ...
> 			ClearOrSaveResult(result);
> 			success = false;
> 
> 
> 			/* and switch to next result */
> 			result_status = PQresultStatus(result);
> 			if (result_status == PGRES_COPY_BOTH ||
> 				result_status == PGRES_COPY_OUT ||
> 				result_status == PGRES_COPY_IN)
> 
> 
> So we called ClearOrSaveResult() with did a PQclear(), and then we go and call
> PQresultStatus().

Greetings,

Andres Freund