Date: Sat, 15 Jan 2022 09:46:01 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Shawn Debnath <sdn@amazon.com>, Julien Rouhaud <rjuju123@gmail.com>,
	Gilles Darold <gilles@darold.net>,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
	Tomas Vondra <tomas.vondra@2ndquadrant.com>,
	Alexander Korotkov <aekorotkov@gmail.com>,
	Anastasia Lubennikova <a.lubennikova@postgrespro.ru>,
	Daniel Gustafsson <daniel@yesql.se>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Thomas Munro <thomas.munro@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: MultiXact/SLRU buffers configuration
Message-ID: <20220115154601.GT14051@telsasoft.com>
References: <B7D61584-6CAC-4CF9-B3D4-7CC52D6C4C5C@yandex-team.ru>
 <15CA416B-3446-462D-902B-4883DD3ADEE6@yandex-team.ru>
 <CA+hUKGLCLDtgDj2Xsf0uBk5WXDCeHxBDDJPsyY7m65Fde-=pyg@mail.gmail.com>
 <B8FACD14-E3AB-4EB3-8CCC-E93697C54F72@yandex-team.ru>
 <CA+hUKGKzPSXYowH=Y8NiuUD8gdyD225-WHaEzXT1E0Sa8RopVQ@mail.gmail.com>
 <494C5E7F-E410-48FA-A93E-F7723D859561@yandex-team.ru>
 <28051640513399@vla1-36b7415cbc1b.qloud-c.yandex.net>
 <20220114092838.gbr6ea7zxbaespsr@jrouhaud>
 <YeH3FU0ypOA+Kdf8@f01898859afd.ant.amazon.com>
 <A66F1597-EC9E-44F2-B1A1-4377016A5053@yandex-team.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <A66F1597-EC9E-44F2-B1A1-4377016A5053@yandex-team.ru>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220115154601.GT14051%40telsasoft.com>
Precedence: bulk

On Sat, Jan 15, 2022 at 12:16:59PM +0500, Andrey Borodin wrote:
> > 15 янв. 2022 г., в 03:20, Shawn Debnath <sdn@amazon.com> написал(а):
> > On Fri, Jan 14, 2022 at 05:28:38PM +0800, Julien Rouhaud wrote:
> >>> PFA rebase of the patchset. Also I've added a patch to combine 
> >>> page_number, page_status, and page_dirty together to touch less 
> >>> cachelines.
> >> 
> >> The cfbot reports some errors on the latest version of the patch:
> >> 
> >> https://cirrus-ci.com/task/6121317215764480
> >> [...]
> >> Could you send a new version?  In the meantime I will switch the patch 
> >> status to Waiting on Author.
> > 
> > I was planning on running a set of stress tests on these patches. Could 
> > we confirm which ones we plan to include in the commitfest?
> 
> Many thanks for your interest. Here's the  latest version.

This is failing to compile under linux and windows due to bitfield syntax.
http://cfbot.cputube.org/andrey-borodin.html

And compile warnings:

slru.c: In function ‘SlruAdjustNSlots’:
slru.c:161:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  161 |  int nbanks = 1;
      |  ^~~
slru.c: In function ‘SimpleLruReadPage_ReadOnly’:
slru.c:530:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  530 |  int bankstart = (pageno & shared->bank_mask) * shared->bank_size;
      |  ^~~

Note that you can test the CI result using any github account without waiting
for the cfbot.  See ./src/tools/ci/README.

-- 
Justin