public inbox for [email protected]  
help / color / mirror / Atom feed
From: Julien Rouhaud <[email protected]>
To: Amul Sul <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: using an end-of-recovery record in all cases
Date: Sun, 16 Jan 2022 12:52:28 +0800
Message-ID: <20220116045228.yym4dxmqsrfkya6r@jrouhaud> (raw)
In-Reply-To: <CAAJ_b95xPx6oHRb5VEatGbp-cLsZApf_9GWGtbv9dsFKiV_VDQ@mail.gmail.com>
References: <[email protected]>
	<CAAJ_b96jh3hJFnFpx7aamZGb63v+NPXPUGdU8dSY0c3OvMT2nA@mail.gmail.com>
	<CA+Tgmoad3x86n6q7RoMHt=_JP8t-TKRL3WmYkn2TXeZ9usjTzA@mail.gmail.com>
	<[email protected]>
	<CAAJ_b94sVCrGKL6pBKTr6_ADL4ehASe3s0P=85JBB=V5zCV6ng@mail.gmail.com>
	<CA+TgmoYj9+XzM-tkgrKaTsRhxmgB7z7oyhONDCzNnKqk86Rxjw@mail.gmail.com>
	<CAAJ_b94RidhUAZT+KUCRsC6t5uKmGWBUPR+O95F8eEw9UVfD2g@mail.gmail.com>
	<CA+TgmobsB-Gs6bCc4-RzgL7KjPBT=kJjDf0_guc1th-VgwKVGg@mail.gmail.com>
	<CAAJ_b96FwTLmayr-nf87c=PoBPqaCLYZ0BVab1MtGfbejdCV1A@mail.gmail.com>
	<CAAJ_b95xPx6oHRb5VEatGbp-cLsZApf_9GWGtbv9dsFKiV_VDQ@mail.gmail.com>

Hi,

On Mon, Oct 18, 2021 at 10:56:53AM +0530, Amul Sul wrote:
> 
> Attached is the rebased and updated version. The patch removes the
> newly introduced PerformRecoveryXLogAction() function. In addition to
> that, removed the CHECKPOINT_END_OF_RECOVERY flag and its related
> code.  Also, dropped changes for bgwriter.c and slot.c in this patch, which
> seem unrelated to this work.

The cfbot reports that this version of the patch doesn't apply anymore:

http://cfbot.cputube.org/patch_36_3365.log
=== Applying patches on top of PostgreSQL commit ID 0c53a6658e47217ad3dd416a5543fc87c3ecfd58 ===
=== applying patch ./v3-0001-Always-use-an-end-of-recovery-record-rather-than-.patch
patching file src/backend/access/transam/xlog.c
[...]
Hunk #14 FAILED at 9061.
Hunk #15 FAILED at 9241.
2 out of 15 hunks FAILED -- saving rejects to file src/backend/access/transam/xlog.c.rej

Can you send a rebased version?  In the meantime I will switch the cf entry to
Waiting on Author.






view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: using an end-of-recovery record in all cases
  In-Reply-To: <20220116045228.yym4dxmqsrfkya6r@jrouhaud>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox