Date: Mon, 17 Jan 2022 08:10:43 +0800
From: Julien Rouhaud <rjuju123@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org,
	Robert Haas <rhaas@postgresql.org>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>,
	Pavel Stehule <pavel.stehule@gmail.com>
Subject: Re: default to to ON_ERROR_STOP=on (Re: psql: exit status with
 multiple -c and -f)
Message-ID: <20220117001043.hgjci4zqt3l4susa@jrouhaud>
References: <20211206150856.GJ17618@telsasoft.com>
 <20211227161021.GO17618@telsasoft.com>
 <1513136.1640626267@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1513136.1640626267@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/20220117001043.hgjci4zqt3l4susa%40jrouhaud>
Precedence: bulk

Hi,

On Mon, Dec 27, 2021 at 12:31:07PM -0500, Tom Lane wrote:
> Justin Pryzby <pryzby@telsasoft.com> writes:
> > I think the current behavior of the regression test SQL scripts is exactly the
> > opposite of what's desirable for almost all other scripts.  The attached makes
> > ON_ERROR_STOP the default, and runs the regression tests with ON_ERROR_STOP=0.
> 
> > Is it viable to consider changing this ?
> 
> I don't think so.  The number of scripts you will break is far greater
> than the number whose behavior will be improved, because people who
> wanted this behavior will already be selecting it.  Maybe this wasn't
> the greatest choice of default, but it's about twenty years too late
> to change it.
> 
> I'd also note that I see a fairly direct parallel to "set -e" in
> shell scripts, which is likewise not the default.
> 
> We could consider documentation changes to make this issue
> more visible, perhaps.  Not sure what would be a good place.

I'm marking the CF entry as returned with feedback as it's been a few weeks
without proposal for documentation change.