Date: Tue, 18 Jan 2022 15:55:58 +0800
From: Julien Rouhaud <rjuju123@gmail.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Is there any documentation on how to correctly create extensions
 in HA(primary-standby) setup?
Message-ID: <20220118075558.nytdwy6b2c7tkvzw@jrouhaud>
References: <CALj2ACXcedBdnBZ3TFY8PBNf60EZ3=gTK0Zrn5bKpSTmh57M7Q@mail.gmail.com>
 <CALj2ACWr6u6pZpHq-NqnYPK8NgXaxTOWsNnmfDxFT=OXrQ_vPg@mail.gmail.com>
 <270122d3-7591-666e-44db-7894e8539c45@enterprisedb.com>
 <CALj2ACVR6mbP9APvFGK4Zs6Yatzn67a+KjM1_FwLeP_AJYHkvw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALj2ACVR6mbP9APvFGK4Zs6Yatzn67a+KjM1_FwLeP_AJYHkvw@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/20220118075558.nytdwy6b2c7tkvzw%40jrouhaud>
Precedence: bulk

Hi,

On Thu, Dec 09, 2021 at 08:19:06AM +0530, Bharath Rupireddy wrote:
> 
> Thanks. Attaching v1 patch specifying the notes there. Please review.

I think that the common terminology is "module", not "extension".  That's
especially important here as this information is also relevant for modules that
may come with an SQL level extension.  This should be made clear in that new
documentation, same for the CREATE EXTENSION part that may not be relevant.

It also seems that this documentation is only aimed for physical replication.
It should also be explicitly stated as it might not be obvious for the intended
readers.


+     [...] set it either via <link linkend="sql-altersystem">ALTER SYSTEM</link>
+     command or <filename>postgresql.conf</filename> file on both primary and
+     standys, reload the <filename>postgresql.conf</filename> file and restart
+     the servers.

Isn't the reload a terrible advice?  By definition changing
shared_preload_libraries isn't compatible with a simple reload and will emit
some error.

+     [...] Create the extension on the primary, there is no need to
+     create it on the standbys as the <link linkend="sql-createextension"><command>CREATE EXTENSION</command></link>
+     command is replicated.

The "no need" here is quite ambiguous, as it seems to indicate that trying to
create the extension on the standby will work but is unnecessary.