Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nA6p2-00039L-1q for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Jan 2022 09:00:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nA6oU-0005vI-CU for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Jan 2022 08:59:30 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nA6oU-0005v8-3O for pgsql-hackers@lists.postgresql.org; Wed, 19 Jan 2022 08:59:30 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nA6oR-00034p-N6 for pgsql-hackers@lists.postgresql.org; Wed, 19 Jan 2022 08:59:29 +0000 Received: by mail-pf1-x42b.google.com with SMTP id w204so1943248pfc.7 for ; Wed, 19 Jan 2022 00:59:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Z3qLsCT8BWY5WhiEA4xjPxApb+Yu515k1RTi8YNSi7E=; b=h99h50RsWHMNWkEGxWGljaG29Y9dG6BBiliLDrU8pIN90k8/GA8Z8amKapFNRMWzxT 3fnJZEjsHIhWv9MgygMupjfvOEmF93nPbCEIeky0w/yMRccYY+OGJXy/n5QdvcI6KqyM 4BH+APeIllhg5BNKaZHh51qsNclyIZFXdmRZlNkOdbiGA4yYwowkLgz4UQnKSttdSo97 iHVHxYAO+7VykkW99KYTGCcXT9Vz1gpaJjPDWfJHFKfygrAaq+/DSEDeu3pq8zDGgRoq 5hE1nk5AACAou83u+Duzl0+DPWMZX/36SOmsBuPUrmcWhEJFHHFZItSQqylU4dJMFeAO 4PfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Z3qLsCT8BWY5WhiEA4xjPxApb+Yu515k1RTi8YNSi7E=; b=FK6a/h908q6gK/cIUlnZnZsjDFPi6z2a/3F3RrVdBDcOQP8IxKNcLVogyZMBKRGupD WOnXkZAJH/SDzVWAp0D12TTxrGBxQmPM2MUq3jtr8IfNArEI9xCbc7XjcL4+wMT4f5Dn U/OylBsf+bUE7YiB3e3QEumbYFUsRXVSxE6DBgaKExAOOCRhwCcUId9U5dTP2qxmJ6oX 6fSaD8y1a0Lpy3E2U/IOiPl18TPE8yAWeRT11DrRZ4ftzy57GcRCHSwiIPjCVRrgCc1+ 1HZgPo4ZSniGYOGJGoyVvXjwglCbRn2UEmT3s+jNPTl4aRKT27u0Af5OoF/eiezYs2X8 OgnA== X-Gm-Message-State: AOAM533f5FckzbNlooYRYWGso5GgRUp14GCQPwkUXvODS9fMaqkuUvw9 pcPFsOlc1EatFP7ysaV0XOU= X-Google-Smtp-Source: ABdhPJzAi/wuUwFRWVtXuNvJJCmGsDIdHyEBf6ob14GKLxW4eGjQcWhmstfPL8Etod/Ejg6Co2lv/g== X-Received: by 2002:a63:4602:: with SMTP id t2mr26831453pga.108.1642582766783; Wed, 19 Jan 2022 00:59:26 -0800 (PST) Received: from jrouhaud (1-171-184-213.dynamic-ip.hinet.net. [1.171.184.213]) by smtp.gmail.com with ESMTPSA id k2sm17090938pgh.11.2022.01.19.00.59.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jan 2022 00:59:26 -0800 (PST) Date: Wed, 19 Jan 2022 16:59:20 +0800 From: Julien Rouhaud To: Tom Lane Cc: Peter Eisentraut , "tanghy.fnst@fujitsu.com" , Japin Li , Kyotaro Horiguchi , Laurenz Albe , "smithpb2250@gmail.com" , "david.zhang@highgo.ca" , "pgsql-hackers@lists.postgresql.org" Subject: Re: Support tab completion for upper character inputs in psql Message-ID: <20220119085920.mzmkzed5vl7k4iwv@jrouhaud> References: <80b093ae-88bd-8d8a-68b9-b535a3ab11be@enterprisedb.com> <54bd7839-f463-ef03-f2d2-ccb8184b9b27@enterprisedb.com> <1068530.1641480996@sss.pgh.pa.us> <3547066.1642272686@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3547066.1642272686@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On Sat, Jan 15, 2022 at 01:51:26PM -0500, Tom Lane wrote: > > I spent some time looking at this patch. I'm not very happy with it, > for two reasons: > [...] On top of that the patch doesn't apply anymore: http://cfbot.cputube.org/patch_36_2979.log === Applying patches on top of PostgreSQL commit ID 5987feb70b5bbb1fc4e64d433f490df08d91dd45 === === applying patch ./v11-0001-Support-tab-completion-with-a-query-result-for-u.patch patching file src/bin/psql/t/010_tab_completion.pl Hunk #1 FAILED at 41. Hunk #2 succeeded at 150 (offset 1 line). 1 out of 2 hunks FAILED -- saving rejects to file src/bin/psql/t/010_tab_completion.pl.rej I'm switching the CF entry to Waiting on Author.