public inbox for [email protected]  
help / color / mirror / Atom feed
From: Andres Freund <[email protected]>
To: James Coleman <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Add last commit LSN to pg_last_committed_xact()
Date: Wed, 19 Jan 2022 19:12:26 -0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAAaqYe-QtHF1CExgvyQZdkdZx-0KCyRsu+ATJTqurWU4Ekt2Vg@mail.gmail.com>
References: <CAAaqYe9QBiAu+j8rBun_JKBRe-3HeKLUhfVVsYfsxQG0VqLXsA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAAaqYe_iKDVB3fvsvsz+Vk0yGDf99-OGVRoJdckA23Fw0B6vqg@mail.gmail.com>
	<[email protected]>
	<CAAaqYe-QtHF1CExgvyQZdkdZx-0KCyRsu+ATJTqurWU4Ekt2Vg@mail.gmail.com>

Hi,

On 2022-01-19 21:23:12 -0500, James Coleman wrote:
>  { oid => '3537', descr => 'get identification of SQL object',
> diff --git a/src/include/storage/proc.h b/src/include/storage/proc.h
> index a58888f9e9..2a026b0844 100644
> --- a/src/include/storage/proc.h
> +++ b/src/include/storage/proc.h
> @@ -258,6 +258,11 @@ struct PGPROC
>  	PGPROC	   *lockGroupLeader;	/* lock group leader, if I'm a member */
>  	dlist_head	lockGroupMembers;	/* list of members, if I'm a leader */
>  	dlist_node	lockGroupLink;	/* my member link, if I'm a member */
> +
> +	/*
> +	 * Last transaction metadata.
> +	 */
> +	XLogRecPtr	lastCommitLSN;		/* cache of last committed LSN */
>  };

Might be worth forcing this to be on a separate cacheline than stuff more
hotly accessed by other backends, like the lock group stuff.

Greetings,

Andres Freund






view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Add last commit LSN to pg_last_committed_xact()
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox