Date: Wed, 19 Jan 2022 21:59:14 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Andrew Dunstan <andrew@dunslane.net>,
	Bruce Momjian <bruce@momjian.us>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade should truncate/remove its logs before running
Message-ID: <20220120035914.GH23027@telsasoft.com>
References: <238201.1640184746@sss.pgh.pa.us>
 <20211222163611.GC17618@telsasoft.com>
 <20220108184857.GI14051@telsasoft.com>
 <Yd00xmV+rdffAQxf@paquier.xyz>
 <20220111200307.GA14051@telsasoft.com>
 <Yd5SOupY+FHbiXLD@paquier.xyz>
 <20220112040813.GD14051@telsasoft.com>
 <YefIHrNYTNH/PML4@paquier.xyz>
 <20220120000540.GG23027@telsasoft.com>
 <YejQiZVgWA1XH6cH@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YejQiZVgWA1XH6cH@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220120035914.GH23027%40telsasoft.com>
Precedence: bulk

On Thu, Jan 20, 2022 at 12:01:29PM +0900, Michael Paquier wrote:
> On Wed, Jan 19, 2022 at 06:05:40PM -0600, Justin Pryzby wrote:
> 
> > I'm not sure these restrictions are needed ?
> 
> This could lead to issues with rmtree() if we are not careful enough,
> no?  We'd had our deal of argument injections with pg_upgrade commands
> in the past (fcd15f1).

We require that the dir not exist, by testing if (mkdir()).
So it's okay if someone specifies ../whatever or $CWD.

-- 
Justin