Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAwYI-0000Ab-Ig for pgsql-hackers@arkaria.postgresql.org; Fri, 21 Jan 2022 16:14:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nAwXk-00039J-Ix for pgsql-hackers@arkaria.postgresql.org; Fri, 21 Jan 2022 16:13:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAwXk-00039A-7v for pgsql-hackers@lists.postgresql.org; Fri, 21 Jan 2022 16:13:40 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nAwXh-0001eh-RC for pgsql-hackers@postgresql.org; Fri, 21 Jan 2022 16:13:39 +0000 Received: by mail-pj1-x102c.google.com with SMTP id l24-20020a17090aec1800b001b55738f633so21690pjy.1 for ; Fri, 21 Jan 2022 08:13:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QM7s1JIBVi4Lmd8ap8EyX1y73reij0x2UGwJagDegbI=; b=iXP1WlHy7FFJLlb6krDjRuYPFn8K0nYKnqjE7zyFRbNCBTJYTZ9pJ8cK9cYwfeuZfe Y/BIU76dyl/5bL6IlxopH7FPuZMrC1OKfdM4g9XYov+hsiam6En3M377WMJEe30uA/3l NcqqRVynXGkrTlCE44iaMEZ4LBrIFFzz7O8lfOLTmEZBSSQKVVPBTCr59GbHxxOtf5yN ngiNJJbHL27BEGquJkqgUgh6VvNCPjcRV/Jko/al7PYV8xbXu8YRL9k+Tx0oAIyVqwE8 9ZrhDQQFtvk22Lz0qC2lc3l6g1uKrG6iWBMDa8YUsbp+idQj/FQrxJnwhCM0yVT3SElo 7LWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QM7s1JIBVi4Lmd8ap8EyX1y73reij0x2UGwJagDegbI=; b=pv7lglRwVQzmL8t9IIFIq7j1EMP4h/Sgha4O5/LdjdVyxpVfDC+FogIraPT2NInq6q enj7dp7Mwk7SsrgeC/035/yHSnDOabTwg8kpbT9Q/6nysyBB3ozbf1Fr6Y0rCS4LXWin DJJbFpsFJnByEKLSXqSKdHdnakC6hUJXguKB/+FSGM3qA8TrcgM36Ozs/qAszj19eh+8 DNWwCvUSrcEJOrZh3+fePt4y7Wz05X+z3aknKitspKPHS45wi4TZii4k/ywrFaGk/q79 UG9npMjfPQmEK5lrjHym14zwytdcNKZaEKbwRdLB0OAiiEyc6X2/+rahmFpIEJBCOkB8 SA+A== X-Gm-Message-State: AOAM530G5rKGhXsmL1CGV0Th0Ts9yqc5QsaD+VpL0BDqRIrxn3a4GIin 9TA0KWAaeOKZ8KBBizNcyMA= X-Google-Smtp-Source: ABdhPJxF3SW7W3zASrhjxrA2vkXxrrVOrIN13/+/HrJkuhK2Zg/6cVQW8xtPRlnA5kc4fwW+R/6i4Q== X-Received: by 2002:a17:902:7b87:b0:14a:bf7b:84da with SMTP id w7-20020a1709027b8700b0014abf7b84damr4592291pll.89.1642781616656; Fri, 21 Jan 2022 08:13:36 -0800 (PST) Received: from jrouhaud (1-171-55-158.dynamic-ip.hinet.net. [1.171.55.158]) by smtp.gmail.com with ESMTPSA id f16sm6993731pfd.118.2022.01.21.08.13.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 08:13:36 -0800 (PST) Date: Sat, 22 Jan 2022 00:13:31 +0800 From: Julien Rouhaud To: Peter Eisentraut Cc: pgsql-hackers , Daniel Verite Subject: Re: ICU for global collation Message-ID: <20220121161331.xn7fhtfg5j2ucilb@jrouhaud> References: <20220110032508.4eyz6m6mpvt622la@jrouhaud> <20220110060027.egvaly4lskylo22f@jrouhaud> <20220111110852.t5oxfga57llm5cy2@jrouhaud> <20220118040246.dewl5pain2gkv2iv@jrouhaud> <171c5f7c-43ee-dbe9-31f9-5e3eb06a54cf@enterprisedb.com> <20220121135119.ywszwl4353v5dzh5@jrouhaud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Jan 21, 2022 at 03:24:02PM +0100, Peter Eisentraut wrote: > On 21.01.22 14:51, Julien Rouhaud wrote: > > Is that change intended? There isn't any usage of the collversionstr before > > the possible error when actual_versionstr is missing. > > I wanted to move it closer to the SysCacheGetAttr() where the "datum" value > is obtained. It seemed weird to get the datum, then do other things, then > decode the datum. Oh ok. It won't make much difference performance-wise, so no objection.