Date: Tue, 25 Jan 2022 10:45:29 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>,
	Andrew Dunstan <andrew@dunslane.net>,
	Bruce Momjian <bruce@momjian.us>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade should truncate/remove its logs before running
Message-ID: <20220125164529.GG23027@telsasoft.com>
References: <20211222163611.GC17618@telsasoft.com>
 <20220108184857.GI14051@telsasoft.com>
 <Yd00xmV+rdffAQxf@paquier.xyz>
 <20220111200307.GA14051@telsasoft.com>
 <Yd5SOupY+FHbiXLD@paquier.xyz>
 <20220112040813.GD14051@telsasoft.com>
 <YefIHrNYTNH/PML4@paquier.xyz>
 <45e7680a-b617-1397-afa0-35a793aacefe@enterprisedb.com>
 <Yek+uQp/kMn2O3aK@paquier.xyz>
 <Ye4IDNnbMQ5IRxv9@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Ye4IDNnbMQ5IRxv9@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220125164529.GG23027%40telsasoft.com>
Precedence: bulk

On Mon, Jan 24, 2022 at 10:59:40AM +0900, Michael Paquier wrote:
> On Thu, Jan 20, 2022 at 07:51:37PM +0900, Michael Paquier wrote:
> > Neat idea.  That would work fine for my case.  So I am fine to stick
> > with this suggestion. 
> 
> I have been looking at this idea, and the result is quite nice, being
> simpler than anything that has been proposed on this thread yet.  We
> get a simpler removal logic, and there is no need to perform any kind
> of sanity checks with the output path provided as long as we generate
> the paths and the dirs after adjust_data_dir().
> 
> Thoughts?

Andrew: you wanted to accommodate any change on the build client, right ?

-- 
Justin