public inbox for [email protected]  
help / color / mirror / Atom feed
From: Kyotaro Horiguchi <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: TAP test to cover "EndOfLogTLI != replayTLI" case
Date: Thu, 27 Jan 2022 16:24:34 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAAJ_b94hsL4_aboiyPipfAEMzaW=OVFSd5h7sqCc+R49f3tY1g@mail.gmail.com>
	<[email protected]>

At Thu, 27 Jan 2022 15:31:37 +0900, Michael Paquier <[email protected]> wrote in 
> On Thu, Jan 20, 2022 at 12:13:08PM +0530, Amul Sul wrote:
> > I found the cause for the test failing on window -- is due to the
> > custom archive command setting which wasn't setting the correct window
> > archive directory path.
> 
> After reading this patch and this thread, I have noticed that you are
> testing the same thing as Heikki here, patch 0001:
> https://www.postgresql.org/message-id/[email protected]
> 
> The patch sent on the other thread has a better description and shape,
> so perhaps we'd better drop what is posted here in favor of the other
> version.  Thoughts?

pg_switch_wal() is more preferable than filling-in a large number of
records as the means to advance segments because it is stable against
changes of wal_segment_size.

As you said, using has_restoring on initializing node_ptr is simpler
than explicitly setting archive_dir from that of another node.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center






view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: TAP test to cover "EndOfLogTLI != replayTLI" case
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox