Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEiDs-0006gV-QZ for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Feb 2022 01:44:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nEiDq-0007hj-Im for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Feb 2022 01:44:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEiDq-0007ha-7f for pgsql-hackers@lists.postgresql.org; Tue, 01 Feb 2022 01:44:42 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nEiDn-0002ak-N0 for pgsql-hackers@lists.postgresql.org; Tue, 01 Feb 2022 01:44:41 +0000 Received: by mail-pg1-x532.google.com with SMTP id p125so13925505pga.2 for ; Mon, 31 Jan 2022 17:44:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ix1RVlgbvPgOkRax5rTPDbFgd1+MujjsYLf24+EfC+k=; b=QivpjqaTEfVXneajQoh997dy26CEoaw03m/km+QyxUyVNTR/LGH/BmvD6cMff3ggr+ pR4LHiHgEWe7MwJSpued0WHoRJ6R3evj/94VaUm05RE1w0JRFfL9Au3uChvv48RVxhgI doX0hT7eSiX9KOIpQWi7VFJ8F1yxJCx7NkkQFdwrFPUHHEutCd6hlxRQ5Q432YG4rUyA zCcnUDPcHAo5NktNdopMDqP1gTAJlVabdK3JmFDna7boJ6JmD1AZjkRYK6lizzcnF0ls 4ZEmbskJCjWMAgUcxCBylDSQFvMMp4Lr1GQSmQacgJNWsP6MFl0LtKbNkDYY8+Vi84ZQ 41xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ix1RVlgbvPgOkRax5rTPDbFgd1+MujjsYLf24+EfC+k=; b=0r8xuRMD001GFj7ePw41ASmrq8q8MmJmpk1glmI4/4TMuMmRmTwPWb4soWRB6zmOKS VWXO70JW1LXs2QlipNRxOqw/yHHlHLbwFGXcJKSdJt4HSyLN2CorlP4XQgm1MncsWUPs GLhcN7mSfkvyWZI7bva5P4wBzjpUsWJxYYL1sPtPJ6HEKz8vC5TpP4f/ET+9bmxE4lxb 7cAwrKLTdJ2DmVSkDpE4uMlywcwqhf9sFnf7DEb14TKPSqZX6KiAnhV2soPcknJ20VdZ 7+kJa5VWDkUYMUvTAR6IQRV6P3k4KFmuds5iRuYtyXqhGRl0Ba/OBh2+RZ8IheAslNhY 3ipg== X-Gm-Message-State: AOAM530CCoEb8heTotbNu/FuEiHEb/ErfLiA1tRfKtWWYXEP8aKlvwU6 wmS0DJSnzdq+Nac8oNMSBv8= X-Google-Smtp-Source: ABdhPJwqwV3VnDKEmQKsSin4ZwyObr88jiWFWPtOhJRWrSg00h27aft1XIz8jy868ByOhK2/OvDD3w== X-Received: by 2002:a05:6a00:2447:: with SMTP id d7mr22677264pfj.64.1643679877796; Mon, 31 Jan 2022 17:44:37 -0800 (PST) Received: from nathanxps13 ([50.54.155.70]) by smtp.gmail.com with ESMTPSA id q4sm5678790pfj.113.2022.01.31.17.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 17:44:37 -0800 (PST) Date: Mon, 31 Jan 2022 17:44:35 -0800 From: Nathan Bossart To: Bharath Rupireddy Cc: Stephen Frost , Kyotaro Horiguchi , "Bossart, Nathan" , Julien Rouhaud , Michael Paquier , PostgreSQL Hackers Subject: Re: Add checkpoint and redo LSN to LogCheckpointEnd log message Message-ID: <20220201014435.GA738413@nathanxps13> References: <20220120.120029.1092463916382268628.horikyota.ntt@gmail.com> <20220128054620.GA654866@nathanxps13> <20220131151100.GR10577@tamriel.snowman.net> <20220131183009.GA660545@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Feb 01, 2022 at 12:23:10AM +0530, Bharath Rupireddy wrote: > On Tue, Feb 1, 2022 at 12:00 AM Nathan Bossart wrote: >> I think the pg_controldata change needs some extra spaces for alignment, >> but otherwise these patches seem reasonable to me. > > Thanks. My bad it was. Changed in v6. LGTM -- Nathan Bossart Amazon Web Services: https://aws.amazon.com