Date: Thu, 3 Feb 2022 13:25:39 -0800
From: Nathan Bossart <nathandbossart@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: "Bossart, Nathan" <bossartn@amazon.com>,
	David Steele <david@pgmasters.net>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	Michael Paquier <michael@paquier.xyz>,
	Magnus Hagander <magnus@hagander.net>,
	Stephen Frost <sfrost@snowman.net>
Subject: Re: archive modules
Message-ID: <20220203212539.GA1082940@nathanxps13>
References: <20220130003148.GA459597@nathanxps13>
 <20220130050141.GA582209@nathanxps13>
 <20220201013608.GA737363@nathanxps13>
 <CA+TgmobN3L+ddDK_CQitfR_dSSoeXVxkUu=d57xioh-mW8EXoQ@mail.gmail.com>
 <20220202224433.GA1036711@nathanxps13>
 <CA+TgmoYJ9pTRdX35E35q=+5zetrpOyBh=QnU532C4zvsL1xWdQ@mail.gmail.com>
 <20220203192747.GA1080581@nathanxps13>
 <CA+Tgmoa+Sp9w2CAkEJ4MuD2sAjePOmVWiYh1yDvVx4P--4ZbUg@mail.gmail.com>
 <20220203211121.GA1081379@nathanxps13>
 <CA+TgmoYDiOPrEAwzf4MAp-RPRo4TgU1MHfuDOBz-FupWfDa74A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="h31gzZEtNLTqOjlF"
Content-Disposition: inline
In-Reply-To: 
 <CA+TgmoYDiOPrEAwzf4MAp-RPRo4TgU1MHfuDOBz-FupWfDa74A@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220203212539.GA1082940%40nathanxps13>
Precedence: bulk


--h31gzZEtNLTqOjlF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Feb 03, 2022 at 04:15:30PM -0500, Robert Haas wrote:
> On Thu, Feb 3, 2022 at 4:11 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
>> On Thu, Feb 03, 2022 at 04:04:33PM -0500, Robert Haas wrote:
>> > So apparently we need to either skip this test when wal_level=minimal,
>> > or force a higher wal_level to be used for this particular test. Not
>> > sure what the existing precedents are, if any.
>>
>> The only precedent I've found so far is test_decoding, which sets wal_level
>> to "logical."  Perhaps we can just set it to "replica" in
>> basic_archive.conf.
> 
> Yeah, that seems to make sense.

024_archive_recovery.pl seems to do something similar.  Patch attached.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

--h31gzZEtNLTqOjlF
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="fix-basic-archive-test.patch"

diff --git a/contrib/basic_archive/basic_archive.conf b/contrib/basic_archive/basic_archive.conf
index b26b2d4144..db029f4b8e 100644
--- a/contrib/basic_archive/basic_archive.conf
+++ b/contrib/basic_archive/basic_archive.conf
@@ -1,3 +1,4 @@
 archive_mode = 'on'
 archive_library = 'basic_archive'
 basic_archive.archive_directory = '.'
+wal_level = 'replica'

--h31gzZEtNLTqOjlF--