Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFfHx-0004DC-90 for pgsql-hackers@arkaria.postgresql.org; Thu, 03 Feb 2022 16:48:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nFfHw-0002Jw-4h for pgsql-hackers@arkaria.postgresql.org; Thu, 03 Feb 2022 16:48:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFfHv-0002Jm-RO for pgsql-hackers@lists.postgresql.org; Thu, 03 Feb 2022 16:48:51 +0000 Received: from mx0a-0050f201.pphosted.com ([148.163.145.86]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFfHt-0003ij-D8 for pgsql-hackers@postgresql.org; Thu, 03 Feb 2022 16:48:51 +0000 Received: from pps.filterd (m0203369.ppops.net [127.0.0.1]) by mx0b-0050f201.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 213Ga2JW003852 for ; Fri, 4 Feb 2022 01:48:46 +0900 Received: from sraihe.sra.co.jp (sraihe.sra.co.jp [221.255.117.38]) by mx0b-0050f201.pphosted.com (PPS) with ESMTP id 3dy1wfsunu-1 for ; Fri, 04 Feb 2022 01:48:46 +0900 Received: from srascb.sra.co.jp (srascb [133.137.8.65]) by sraihe.sra.co.jp (Postfix) with ESMTP id B665B2A684A for ; Fri, 4 Feb 2022 01:48:45 +0900 (JST) Received: from sranhm.sra.co.jp (osspc47 [133.137.174.164]) by srascb.sra.co.jp (Postfix) with ESMTP id 968455800B7 for ; Fri, 4 Feb 2022 01:48:45 +0900 (JST) Received: from yugon-CFSV7-1 (sraihb-hub.sra.co.jp [133.137.8.6]) by sranhm.sra.co.jp (Postfix) with SMTP id 7E5FF341546 for ; Fri, 4 Feb 2022 01:48:45 +0900 (JST) Date: Fri, 4 Feb 2022 01:46:34 +0900 From: Yugo NAGATA To: pgsql-hackers@postgresql.org Subject: Fix CheckIndexCompatible comment Message-Id: <20220204014634.b39314f278ff4ae3de96e201@sraoss.co.jp> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Fri__4_Feb_2022_01_46_34_+0900_WpqiB_f.g/OriyhI" X-Proofpoint-GUID: 9ZGPpintGetgnUjGlKX0RU5MYwhOJBy4 X-Proofpoint-ORIG-GUID: 9ZGPpintGetgnUjGlKX0RU5MYwhOJBy4 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10247 signatures=673430 X-Proofpoint-Spam-Details: rule=spam_low_notspam policy=spam_low score=0 suspectscore=0 mlxscore=0 bulkscore=0 malwarescore=0 adultscore=6 clxscore=1034 impostorscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 mlxlogscore=295 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202030101 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --Multipart=_Fri__4_Feb_2022_01_46_34_+0900_WpqiB_f.g/OriyhI Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Hello, I found a old parameter name 'heapRelation' in the comment of CheckIndexCompatible. This parameter was removed by 5f173040. Attached is a patch to remove it from the comment. Regards, Yugo Nagata -- Yugo NAGATA --Multipart=_Fri__4_Feb_2022_01_46_34_+0900_WpqiB_f.g/OriyhI Content-Type: text/x-diff; name="fix_CheckIndexCompatible_comment.patch" Content-Disposition: attachment; filename="fix_CheckIndexCompatible_comment.patch" Content-Transfer-Encoding: 7bit diff --git a/src/backend/commands/indexcmds.c b/src/backend/commands/indexcmds.c index 560dcc87a2..95cb15cbb9 100644 --- a/src/backend/commands/indexcmds.c +++ b/src/backend/commands/indexcmds.c @@ -129,7 +129,6 @@ typedef struct ReindexErrorInfo * prospective index definition, such that the existing index storage * could become the storage of the new index, avoiding a rebuild. * - * 'heapRelation': the relation the index would apply to. * 'accessMethodName': name of the AM to use. * 'attributeList': a list of IndexElem specifying columns and expressions * to index on. --Multipart=_Fri__4_Feb_2022_01_46_34_+0900_WpqiB_f.g/OriyhI--