Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nH14X-0003zk-2o for pgsql-hackers@arkaria.postgresql.org; Mon, 07 Feb 2022 10:16:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nH14W-0005Ej-1M for pgsql-hackers@arkaria.postgresql.org; Mon, 07 Feb 2022 10:16:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nH14V-0005Ea-O5 for pgsql-hackers@lists.postgresql.org; Mon, 07 Feb 2022 10:16:35 +0000 Received: from mx0b-0050f201.pphosted.com ([148.163.141.54]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nH14S-00040R-IG for pgsql-hackers@postgresql.org; Mon, 07 Feb 2022 10:16:35 +0000 Received: from pps.filterd (m0203370.ppops.net [127.0.0.1]) by mx0b-0050f201.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 216LuohE008672 for ; Mon, 7 Feb 2022 19:16:30 +0900 Received: from sraihe.sra.co.jp (sraihe.sra.co.jp [221.255.117.38]) by mx0b-0050f201.pphosted.com (PPS) with ESMTP id 3e170u1vrm-1 for ; Mon, 07 Feb 2022 19:16:29 +0900 Received: from srascb.sra.co.jp (srascb [133.137.8.65]) by sraihe.sra.co.jp (Postfix) with ESMTP id 0B0EE2A684B for ; Mon, 7 Feb 2022 19:16:29 +0900 (JST) Received: from sranhm.sra.co.jp (osspc47 [133.137.174.164]) by srascb.sra.co.jp (Postfix) with ESMTP id F0DE0580295 for ; Mon, 7 Feb 2022 19:16:28 +0900 (JST) Received: from yugon-CFSV7-1 (sraihb-hub.sra.co.jp [133.137.8.6]) by sranhm.sra.co.jp (Postfix) with SMTP id D2CD334162A; Mon, 7 Feb 2022 19:16:28 +0900 (JST) Date: Mon, 7 Feb 2022 19:14:18 +0900 From: Yugo NAGATA To: Fujii Masao Cc: pgsql-hackers@postgresql.org Subject: Re: Fix CheckIndexCompatible comment Message-Id: <20220207191418.2bd9808dc875e9f4601380c2@sraoss.co.jp> In-Reply-To: References: <20220204014634.b39314f278ff4ae3de96e201@sraoss.co.jp> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Mon__7_Feb_2022_19_14_18_+0900_onOSAJJ2d1mCqjXh" X-Proofpoint-GUID: HQQU0Wr71zY6GQXv0uiItxRwFm6w1rfG X-Proofpoint-ORIG-GUID: HQQU0Wr71zY6GQXv0uiItxRwFm6w1rfG X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10250 signatures=673430 X-Proofpoint-Spam-Details: rule=spam_low_notspam policy=spam_low score=0 clxscore=1034 bulkscore=0 malwarescore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 impostorscore=0 mlxlogscore=707 phishscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202070067 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --Multipart=_Mon__7_Feb_2022_19_14_18_+0900_onOSAJJ2d1mCqjXh Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Hello, Fujii-san, On Fri, 4 Feb 2022 09:08:22 +0900 Fujii Masao wrote: > > > On 2022/02/04 1:46, Yugo NAGATA wrote: > > Hello, > > > > I found a old parameter name 'heapRelation' in the comment > > of CheckIndexCompatible. This parameter was removed by 5f173040. > > > > Attached is a patch to remove it from the comment. > > Thanks for the report! I agree to remove the mention of parameter already dropped, from the comment. OTOH, I found CheckIndexCompatible() now has "oldId" parameter but there is no comment about it though there are comments about other parameters. Isn't it better to add the comment about "oldId"? Agreed. I updated the patch to add a comment about 'oldId'. Regards, Yugo Nagata -- Yugo NAGATA --Multipart=_Mon__7_Feb_2022_19_14_18_+0900_onOSAJJ2d1mCqjXh Content-Type: text/x-diff; name="v2_fix_CheckIndexCompatible_comment.patch" Content-Disposition: attachment; filename="v2_fix_CheckIndexCompatible_comment.patch" Content-Transfer-Encoding: 7bit diff --git a/src/backend/commands/indexcmds.c b/src/backend/commands/indexcmds.c index 560dcc87a2..408ffc70f6 100644 --- a/src/backend/commands/indexcmds.c +++ b/src/backend/commands/indexcmds.c @@ -129,7 +129,7 @@ typedef struct ReindexErrorInfo * prospective index definition, such that the existing index storage * could become the storage of the new index, avoiding a rebuild. * - * 'heapRelation': the relation the index would apply to. + * 'oldId': the existing index's relation OID * 'accessMethodName': name of the AM to use. * 'attributeList': a list of IndexElem specifying columns and expressions * to index on. --Multipart=_Mon__7_Feb_2022_19_14_18_+0900_onOSAJJ2d1mCqjXh--