Date: Mon, 7 Feb 2022 21:07:28 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-hackers@lists.postgresql.org, bruce@momjian.us,
	tgl@sss.pgh.pa.us
Subject: Re: GUC flags
Message-ID: <20220208030727.GH31460@telsasoft.com>
References: <YfDqSVZlzdzZO9x6@paquier.xyz>
 <20220128043621.GA23027@telsasoft.com>
 <YfTg/WHNLVVygy8v@paquier.xyz>
 <20220130001849.GR23027@telsasoft.com>
 <Yfdw9WWJ/BMl7QYd@paquier.xyz>
 <20220131225645.GZ23027@telsasoft.com>
 <Yf9YGSwPiMu0c7fP@paquier.xyz>
 <YgCGjDK/b13shS0o@paquier.xyz>
 <20220207030414.GC31460@telsasoft.com>
 <YgHK56v7NYXGso+x@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YgHK56v7NYXGso+x@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220208030727.GH31460%40telsasoft.com>
Precedence: bulk

On Tue, Feb 08, 2022 at 10:44:07AM +0900, Michael Paquier wrote:
> What do you think about the updated version attached?  I have applied
> the addition of config_data() separately.

Looks fine

> +	# Check if this line matches a GUC parameter.
> +	if ($line =~ m/^#?([_[:alpha:]]+) (= .*|[^ ]*$)/)

I think this is the regex I wrote to handle either "name = value" or "name
value", which was needed between f47ed79cc..4d7c3e344.   See skip_equals.

It's fine the way it is, but could also remove the 2nd half of the alternation
(|), since GUCs shouldn't be added to sample.conf without '='.

-- 
Justin