Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHp9j-0003Ru-H9 for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Feb 2022 15:45:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nHp9h-0004gn-Sz for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Feb 2022 15:45:17 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHp9g-0004gQ-V9 for pgsql-hackers@lists.postgresql.org; Wed, 09 Feb 2022 15:45:17 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHp9Z-0000v2-HI for pgsql-hackers@postgresql.org; Wed, 09 Feb 2022 15:45:15 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 770805C01EF; Wed, 9 Feb 2022 10:45:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 09 Feb 2022 10:45:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=1GG9cjpt0LsV0+ueNDckXVyBP/sRK4RlCXDR7ZrOYkc=; b=GYtZP/n0 +kpQH6GiQlZ45kAGt8wCQ7wt5WnFTeIwSgs01ygijyVVc/pxOBhby4sSH7i7NQqj 65GOkVIMbtFU3k586gTfmeJAiHUz3iJsS/uEw0uvHRyWX573ormOLfp6L+nc0yJh NAl3Ke89zVRzhatj/R5R4h6kSfkjcoD+W/X5SWog0QOKvqA9pNrOqbUbDPQUourl 1FI3Li7KABZdBzI5/oTtJnypIO4dVKpb8S6AJlvtV6Deaf5gTYklPTiZodftkPxQ 4EEt+ehoM5q82xAPRocO9PpwyN5F36b4E9m4eIDr+v45GPQChSD1TI1sfutBKWVG YD/F7ewFaN3zbw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrheelgdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfggtggugfgjsehtkeertd dttdejnecuhfhrohhmpeetlhhvrghrohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvges rghlvhhhrdhnohdqihhprdhorhhgqeenucggtffrrghtthgvrhhnpedujeevjeffjeevud dutedvkeeiueeitddvieelfeekveejudefgeeuvdejhfeuleenucffohhmrghinhepvghn thgvrhhprhhishgvuggsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomheprghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 9 Feb 2022 10:45:06 -0500 (EST) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id AC8372A0984; Wed, 9 Feb 2022 12:45:02 -0300 (-03) Date: Wed, 9 Feb 2022 12:45:02 -0300 From: Alvaro Herrera To: Dong Wook Lee Cc: Ranier Vilela , pgsql-hackers@postgresql.org Subject: Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c) Message-ID: <202202091545.eatdppxex2yt@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Our style is that we group all declarations in a block to appear at the top. We don't mix declarations and statements. -- Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/