Date: Fri, 11 Feb 2022 09:29:44 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Jeevan Ladhe <jeevanladhe.os@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Dipesh Pandit <dipesh.pandit@gmail.com>,
	Abhijit Menon-Sen <ams@toroid.org>,
	Dmitry Dolgov <9erthalion6@gmail.com>,
	Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>,
	Mark Dilger <mark.dilger@enterprisedb.com>,
	pgsql-hackers@postgresql.org,
	tushar <tushar.ahuja@enterprisedb.com>
Subject: Re: refactoring basebackup.c
Message-ID: <20220211152944.GD31460@telsasoft.com>
References: 
 <CA+TgmoboJJE6M+u4f2E9vKaKGVq6jKync81Bi1jFW8QChscwOg@mail.gmail.com>
 <CA+TgmoYzYVwkDpwHru5+Lf5f0u4cTN6FeBLsJeHxXTBS7v=11A@mail.gmail.com>
 <YgPEhynPPLUFf7x3@toroid.org>
 <CAN1g5_FEDTQXk8h_bUQcc0ULKco=Tv=_QGuiwJ73Qay=T2monQ@mail.gmail.com>
 <CANm22Cj4qakrKy5Evkt29tnW9WqqgfB1u3O_btwYGhPp_M18pw@mail.gmail.com>
 <CAN1g5_FeDmiA9D8wdG2W6Lkq5CpubxOAqTmd2et9hsinTJtsMQ@mail.gmail.com>
 <CANm22Cg9cArXEaYgHVZhCnzPLfqXCZLAzjwTq7Fc0quXRPfbxA@mail.gmail.com>
 <CAN1g5_FrApD0OFbWMF8PRF9W+EAPEV6wS7cCJp-h0qMe7cg8aA@mail.gmail.com>
 <CA+TgmoYUDEJga2qV_XbAZ=pGEBaOsgFmzZ6Ac4_sRwOm_+UeHA@mail.gmail.com>
 <CANm22CgPb1qZRHxqr6jzP2Xt_c3=6TiCBv_AB5G9eqBP90XDgw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CANm22CgPb1qZRHxqr6jzP2Xt_c3=6TiCBv_AB5G9eqBP90XDgw@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220211152944.GD31460%40telsasoft.com>
Precedence: bulk

On Fri, Feb 11, 2022 at 08:35:25PM +0530, Jeevan Ladhe wrote:
> Thanks Robert for the bravity :-)

FYI: there's a couple typos in the last 2 patches.

I added them to my typos branch; feel free to wait until April if you'd prefer
to see them fixed in bulk.

diff --git a/doc/src/sgml/ref/pg_basebackup.sgml b/doc/src/sgml/ref/pg_basebackup.sgml
index 53aa40dcd19..649b91208f3 100644
--- a/doc/src/sgml/ref/pg_basebackup.sgml
+++ b/doc/src/sgml/ref/pg_basebackup.sgml
@@ -419,7 +419,7 @@ PostgreSQL documentation
        <para>
         The compression method can be set to <literal>gzip</literal> or
         <literal>lz4</literal>, or <literal>none</literal> for no
-        compression. A compression level can be optionally specified, by
+        compression. A compression level can optionally be specified, by
         appending the level number after a colon (<literal>:</literal>). If no
         level is specified, the default compression level will be used. If
         only a level is specified without mentioning an algorithm,
@@ -440,7 +440,7 @@ PostgreSQL documentation
         <literal>-Xstream</literal>, <literal>pg_wal.tar</literal> will
         be compressed using <literal>gzip</literal> if client-side gzip
         compression is selected, but will not be compressed if server-side
-        compresion or LZ4 compresion is selected.
+        compression or LZ4 compression is selected.
        </para>
       </listitem>
      </varlistentry>