Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIzh4-0006Ff-UK for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Feb 2022 21:12:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nIzh3-0004Rx-Pw for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Feb 2022 21:12:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIzh3-0004Ro-C1 for pgsql-hackers@lists.postgresql.org; Sat, 12 Feb 2022 21:12:33 +0000 Received: from mail-io1-xd2b.google.com ([2607:f8b0:4864:20::d2b]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nIzgv-0007kq-Eh for pgsql-hackers@postgresql.org; Sat, 12 Feb 2022 21:12:32 +0000 Received: by mail-io1-xd2b.google.com with SMTP id p63so15543838iod.11 for ; Sat, 12 Feb 2022 13:12:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RP5NiFfbn7XqjI/Iy9/PPelLnni3q8cbLKeP7qQr1Yc=; b=cnI1r+YLbg2WiohVgNrgKMdlnn9g10tawwNZi12P5Weo8OJebqeoztwFJmQW+likSH /155Gcqvq7vKer2xbNetcgqItcb6h2jmqW5fHP379HJ1qeIwalXa6aot/VPtL4kSVKNa XZyDSdAb42q4Xqnm0UEQoqWdxyx+d2X0MMeFKX22K9Tal4deN6gbrLw0AkkOo/txuwHM Ss5ZBeJ4gy/U8pydeI4UbHa5t4d2M7+Kbu3T0ryzdFoxDZB2goM0BeoAgnojk9lOlQoS v4c0hamCj8yowcahNwknVk6zw/DhySkXFvOKzhYw/uvAqzk+Pw5MwARRiRJKM28ipoQc +vBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RP5NiFfbn7XqjI/Iy9/PPelLnni3q8cbLKeP7qQr1Yc=; b=3Cn2InU3Wz6VIIdJPtyqy9ZgjXQgKJvh90fiG2WJIKXUh22ZHlJQ1pXmPYvJdtXe5G myedtY8NtfM1wR5/PxbeUbt0D1yJ2Piq3D+9jekHPuugZ3QLy5OEzXbbprM2d2z+qnS1 qDhantdLJRir82yASspZ6h4fsrT0EbOy65cM57C/Jpo23zeMB+DuDzoQYajJ7TGV/dgW jLm5WxDPUzfrY8R77rYdQkKvvq6eTG9+EBriU09wFiLq/JAJnvmmaniqj1KNi1kvpQlC ruueo3Wtjo6D+8/xMi0qFDGKKiugyFK03mJ8Cpm81tDgjXEtIa+0jZm1V1hBpeHi5r1U ecJA== X-Gm-Message-State: AOAM532tyc3MJKCPO9bVtpf7UNLVFFrIjplCS7q0B//v80jQrrpKzeC/ Supm5YILHOQC3xa1Eqkpp4o7xg== X-Google-Smtp-Source: ABdhPJzNa9OFDvVHsKCFJb9ZIHG1eAHOa3DinuSCYRNGybJshLCgpuP0aTnZHCGg2KycufzS1vSSSA== X-Received: by 2002:a02:3b67:: with SMTP id i39mr4158667jaf.62.1644700342403; Sat, 12 Feb 2022 13:12:22 -0800 (PST) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id l16sm12547868ilc.54.2022.02.12.13.12.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Feb 2022 13:12:21 -0800 (PST) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id 369658044FC; Sat, 12 Feb 2022 15:12:21 -0600 (CST) Date: Sat, 12 Feb 2022 15:12:21 -0600 From: Justin Pryzby To: Jeevan Ladhe Cc: Robert Haas , Dipesh Pandit , Abhijit Menon-Sen , Dmitry Dolgov <9erthalion6@gmail.com>, Jeevan Ladhe , Mark Dilger , pgsql-hackers@postgresql.org, tushar Subject: Re: refactoring basebackup.c Message-ID: <20220212211220.GJ31460@telsasoft.com> References: <20220211152944.GD31460@telsasoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220211152944.GD31460@telsasoft.com> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk The LZ4 patches caused new compiler warnings. It's the same issue that was fixed at 71cbbbbe8 for gzip. I think they would've been visible in the CI environment, too. https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=wrasse&dt=2022-02-12%2005%3A08%3A48&stg=make "/export/home/nm/farm/studio64v12_6/HEAD/pgsql.build/../pgsql/src/backend/replication/basebackup_lz4.c", line 87: warning: Function has no return statement : bbsink_lz4_new https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=bowerbird&dt=2022-02-12%2013%3A11%3A20&stg=make https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=hamerkop&dt=2022-02-12%2010%3A04%3A08&stg=make warning C4715: 'bbsink_lz4_new': not all control paths return a value https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=anole&dt=2022-02-12%2005%3A46%3A44&stg=make "basebackup_lz4.c", line 87: warning #2940-D: missing return statement at end of non-void function "bbsink_lz4_new" https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=wrasse&dt=2022-02-12%2005%3A08%3A48&stg=make "/export/home/nm/farm/studio64v12_6/HEAD/pgsql.build/../pgsql/src/backend/replication/basebackup_lz4.c", line 87: warning: Function has no return statement : bbsink_lz4_new