Date: Sat, 12 Feb 2022 21:29:55 -0800
From: Andres Freund <andres@anarazel.de>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Noah Misch <noah@leadboat.com>,
	Julien Rouhaud <rjuju123@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Andrew Dunstan <andrew@dunslane.net>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Rewriting the test of pg_upgrade as a TAP test - take three -
 remastered set
Message-ID: <20220213052955.dh7lheehit7bsemf@alap3.anarazel.de>
References: <YbgsLG0q4n9f0JBE@paquier.xyz>
 <20211214061449.ynrygtcddn3ujunn@alap3.anarazel.de>
 <YblJLJKUZYI4Pqbq@paquier.xyz>
 <Ybqpy4nS6bMq5Qud@paquier.xyz>
 <YdVS+X4SNXO93Oib@paquier.xyz>
 <Yd0uUcGyYJrEPshD@paquier.xyz>
 <20220115055239.6i5mp7ujtcpto2mg@jrouhaud>
 <YeYj4DU5qY/rtKXT@paquier.xyz>
 <20220213045041.qhbw3ue6xmojts6c@alap3.anarazel.de>
 <CA+hUKGJDZt0MRhVSaaO5DX8KLjWf9RPD4YcsnfTSRcRjzCoY1g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+hUKGJDZt0MRhVSaaO5DX8KLjWf9RPD4YcsnfTSRcRjzCoY1g@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/20220213052955.dh7lheehit7bsemf%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2022-02-13 18:07:30 +1300, Thomas Munro wrote:
> On Sun, Feb 13, 2022 at 5:50 PM Andres Freund <andres@anarazel.de> wrote:
> >> > +# required for 027_stream_regress.pl
> >> > +REGRESS_OUTPUTDIR=$(abs_top_builddir)/src/test/recovery
> >> > +export REGRESS_OUTPUTDIR
> >>
> >> Why do we need this?
> >
> > The Make macro "prove_check" (src/Makefile.global.in) always changes
> > to the source directory to run TAP tests. Without an explicit
> > directive to control where regression test output goes, it got
> > splattered all over the source tree in VPATH builds. I didn't see an
> > existing way to adjust that (did I miss something?). Hence desire to
> > pass down a path in the build tree. Better ideas welcome.
> 
> I thought it was a goal that VPATH builds shouldn't pollute the source
> tree, but the Make macro prove_check is explicitly doing so by
> default.  Perhaps *that* should be fixed?

Sure, prove changes into the source dir. But we don't put test data / output
into the source? That's what TESTDIR is used for:

	# Determine output directories, and create them.  The base path is the
	# TESTDIR environment variable, which is normally set by the invoking
	# Makefile.
	$tmp_check = $ENV{TESTDIR} ? "$ENV{TESTDIR}/tmp_check" : "tmp_check";
	$log_path = "$tmp_check/log";

Afaics all the "regress test inside tap test" cases would need to do is to pass
--outputdir=${PostgreSQL::Test::Utils::tmp_check} and you'd get exactly the same path as
REGRESS_OUTPUTDIR currently provides.

I only use vpath builds, and I don't see any tap test data / log in the source
tree....

Greetings,

Andres Freund