Date: Sun, 13 Feb 2022 14:55:26 -0800
From: Andres Freund <andres@anarazel.de>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Noah Misch <noah@leadboat.com>,
	Julien Rouhaud <rjuju123@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Andrew Dunstan <andrew@dunslane.net>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Rewriting the test of pg_upgrade as a TAP test - take three -
 remastered set
Message-ID: <20220213225526.vtxdyeguyibliert@alap3.anarazel.de>
References: <YblJLJKUZYI4Pqbq@paquier.xyz>
 <Ybqpy4nS6bMq5Qud@paquier.xyz>
 <YdVS+X4SNXO93Oib@paquier.xyz>
 <Yd0uUcGyYJrEPshD@paquier.xyz>
 <20220115055239.6i5mp7ujtcpto2mg@jrouhaud>
 <YeYj4DU5qY/rtKXT@paquier.xyz>
 <20220213045041.qhbw3ue6xmojts6c@alap3.anarazel.de>
 <CA+hUKGJDZt0MRhVSaaO5DX8KLjWf9RPD4YcsnfTSRcRjzCoY1g@mail.gmail.com>
 <20220213052955.dh7lheehit7bsemf@alap3.anarazel.de>
 <CA+hUKG+z7fpFOHRZfRn9iJKuCK5h-Nyfj+evFSMGu9nt=2TwmA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+hUKG+z7fpFOHRZfRn9iJKuCK5h-Nyfj+evFSMGu9nt=2TwmA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/20220213225526.vtxdyeguyibliert%40alap3.anarazel.de>
Precedence: bulk

On 2022-02-14 11:23:18 +1300, Thomas Munro wrote:
> On Sun, Feb 13, 2022 at 6:29 PM Andres Freund <andres@anarazel.de> wrote:
> > Afaics all the "regress test inside tap test" cases would need to do is to pass
> > --outputdir=${PostgreSQL::Test::Utils::tmp_check} and you'd get exactly the same path as
> > REGRESS_OUTPUTDIR currently provides.
> 
> Ahh, right.  I assume it still needs perl2host() treatment for MSYS2
> systems, because jacana's log shows TESTDIR is set to a Unixoid path
> that I assume pg_regress's runtime can't use.  That leads to the
> attached.

Looks sane to me.