Date: Tue, 15 Feb 2022 10:10:34 -0800
From: Andres Freund <andres@anarazel.de>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	"Bossart, Nathan" <bossartn@amazon.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Julien Rouhaud <rjuju123@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Avoid erroring out when unable to remove or parse logical
 rewrite files to save checkpoint work
Message-ID: <20220215181034.nyhd6fwzyg3vgxls@alap3.anarazel.de>
References: <20220127010109.GA352793@nathanxps13>
 <CALj2ACWgKS=ZUJ0xcXhbqieJXMQxncLMQRx6nwtVc9Fp5H58RA@mail.gmail.com>
 <20220201235538.GA740616@nathanxps13>
 <CALj2ACXzMf+8-KoREutAA40MrC4sMEY2P1aLFD_RYysC1M2CZQ@mail.gmail.com>
 <20220202183738.GA746893@nathanxps13>
 <CALj2ACXGwc5UBx1Jc2wacqEM1oBmFHjRHxvTDA+X48sE7ObcFQ@mail.gmail.com>
 <20220204000340.GA1164333@nathanxps13>
 <CALj2ACWRbT2LxQq+7so3NdKest0beoYUaZShDy7OvojcstnQOA@mail.gmail.com>
 <20220215170952.2ruszfrv6qvirmhq@alap3.anarazel.de>
 <20220215175752.GA2413813@nathanxps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220215175752.GA2413813@nathanxps13>
Archived-At: <https://www.postgresql.org/message-id/20220215181034.nyhd6fwzyg3vgxls%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2022-02-15 09:57:53 -0800, Nathan Bossart wrote:
> IIUC you are advocating for something more like the attached patches.

At least for patch 1 yes. Don't have the cycles just now to look at the
others.

I generally think it'd be a good exercise to go through an use
get_dirent_type() in nearly all ReadDir() style loops - it's a nice efficiency
win in general, and IIRC a particularly big one on windows.

It'd probably be good to add a reference to get_dirent_type() to
ReadDir[Extended]()'s docs.

Greetings,

Andres Freund